From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ED66C433E1 for ; Wed, 24 Mar 2021 21:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F21F561A21 for ; Wed, 24 Mar 2021 21:00:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231396AbhCXU7x (ORCPT ); Wed, 24 Mar 2021 16:59:53 -0400 Received: from mail.kernel.org ([198.145.29.99]:57268 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238052AbhCXU70 (ORCPT ); Wed, 24 Mar 2021 16:59:26 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id E2EF861A09; Wed, 24 Mar 2021 20:59:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616619566; bh=CvO16Php+LSKrebIn3eKeKJqJUlKnyMhF+uKSaiJxsY=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Z75QFUuND2/N3oYguYuJDghMN+pYcW21T6GJW5kCWWv9NC0amLOdzwLLTT/phFxXf 8sjp9K648/39IKuIhZ64DSbo0crjcm/5oHwqyQuxL0LMjQfluxerBZrKD+hx4eK9Y0 pGPGnIWfmPY8ie6FYk83hB/1/z2DIPsokW2c6WQGnFUv5nVoBkzI3tpUJh1mfjGppF cMVaqNQuqCyR3bI1qEZM9S06W0nOCLmhXqsxfyXiuxu6osUxLxMlWfTSjcSIzCKNta MWKIoMaW/AEwGRDZkTstSw59qRj2bekbsfBFuEta2o5QdETWUnSR5hzR3iDoWHW71A yvqFBGff6/70g== Date: Wed, 24 Mar 2021 21:59:22 +0100 From: Marek =?UTF-8?B?QmVow7pu?= To: Rob Herring Cc: netdev@vger.kernel.org, Andrew Lunn , "David S . Miller" , Florian Fainelli , Heiner Kallweit , Russell King , devicetree@vger.kernel.org, pali@kernel.org Subject: Re: [PATCH net-next 1/2] dt-bindings: ethernet-controller: create a type for PHY interface modes Message-ID: <20210324215922.74f64e5f@thinkpad> In-Reply-To: <20210324200706.GA3528805@robh.at.kernel.org> References: <20210324103556.11338-1-kabel@kernel.org> <20210324103556.11338-2-kabel@kernel.org> <20210324200706.GA3528805@robh.at.kernel.org> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 24 Mar 2021 14:07:06 -0600 Rob Herring wrote: > On Wed, Mar 24, 2021 at 11:35:55AM +0100, Marek Beh=C3=BAn wrote: > > In order to be able to define a property describing an array of PHY > > interface modes, we need to change the current scalar > > `phy-connection-type`, which lists the possible PHY interface modes, to > > an array of length 1 (otherwise we would need to define the same list at > > two different places). > >=20 > > Moreover Rob Herring says that we cannot reuse the values of a property; > > we need to $ref a type. > >=20 > > Move the definition of possible PHY interface modes from the > > `phy-connection-type` property to an array type definition > > `phy-connection-type-array`, and simply reference this type in the > > original property. =20 >=20 > Why not just extend phy-connection-type to support more than 1 entry? Hmm, that would be even better, although it would complicate the Russell's marvell10g patches a little if we want the code to be backward compatible with older device trees. I will look into this. Marek