From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64DFC433C1 for ; Tue, 30 Mar 2021 10:14:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6DA6E619AE for ; Tue, 30 Mar 2021 10:14:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231607AbhC3KOH (ORCPT ); Tue, 30 Mar 2021 06:14:07 -0400 Received: from foss.arm.com ([217.140.110.172]:56126 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231537AbhC3KNx (ORCPT ); Tue, 30 Mar 2021 06:13:53 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id ABF11ED1; Tue, 30 Mar 2021 03:13:51 -0700 (PDT) Received: from bogus (unknown [10.57.57.89]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A0BF3F792; Tue, 30 Mar 2021 03:13:50 -0700 (PDT) Date: Tue, 30 Mar 2021 11:13:40 +0100 From: Sudeep Holla To: Samuel Holland Cc: Andre Przywara , Sudeep Holla , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-sunxi@googlegroups.com Subject: Re: [RFC PATCH] arm64: dts: allwinner: a64/h5: Add CPU idle states Message-ID: <20210330101330.eaanzt5f3bhsn7df@bogus> References: <20210322062514.40747-1-samuel@sholland.org> <20210323015627.08f9afd6@slackpad.fritz.box> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 23, 2021 at 11:44:50PM -0500, Samuel Holland wrote: > 3) Modify the Linux PSCI client to respect PSCI_FEATURES when setting > psci_ops.cpu_suspend. cpuidle-psci checks for this function before > setting up idle states. We don't call PSCI_FEATURES on mandatory functions as it may not return anything meaningful for such mandatory functions(as that is not mandated in the spec). In short NACK to add PSCI_FEATURES check for mandatory functions. -- Regards, Sudeep