From: Mark Brown <broonie@kernel.org>
To: Shengjiu Wang <shengjiu.wang@nxp.com>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: ak5558: Add support for ak5552
Date: Tue, 30 Mar 2021 16:05:21 +0100 [thread overview]
Message-ID: <20210330150521.GD4976@sirena.org.uk> (raw)
In-Reply-To: <1617085972-6094-1-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 333 bytes --]
On Tue, Mar 30, 2021 at 02:32:51PM +0800, Shengjiu Wang wrote:
> +static const struct snd_kcontrol_new ak5552_snd_controls[] = {
> + SOC_ENUM("AK5552 Monaural Mode", ak5552_mono_enum[0]),
> + SOC_ENUM("AK5552 Digital Filter", ak5558_adcset_enum[0]),
> +};
It's a bit weird to have AK5552 in the control name - any reason for
that?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-03-30 15:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 6:32 [PATCH 1/2] ASoC: ak5558: Add support for ak5552 Shengjiu Wang
2021-03-30 6:32 ` [PATCH 2/2] ASoC: dt-bindings: ak5558: Add compatible string " Shengjiu Wang
2021-03-30 22:46 ` Rob Herring
2021-03-30 15:05 ` Mark Brown [this message]
2021-03-31 5:45 ` [PATCH 1/2] ASoC: ak5558: Add support " Shengjiu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210330150521.GD4976@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).