devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Emil Velikov <emil.l.velikov@gmail.com>
To: kernel@collabora.com, Ezequiel Garcia <ezequiel@collabora.com>,
	Philipp Zabel <p.zabel@pengutronix.de>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rockchip@lists.infradead.org
Cc: emil.l.velikov@gmail.com
Subject: [PATCH v4 1/9] media: hantro: use G1_REG_INTERRUPT directly for the mpeg2
Date: Thu,  1 Apr 2021 15:43:28 +0100	[thread overview]
Message-ID: <20210401144336.2495479-2-emil.l.velikov@gmail.com> (raw)
In-Reply-To: <20210401144336.2495479-1-emil.l.velikov@gmail.com>

From: Emil Velikov <emil.velikov@collabora.com>

Use the register directly over the existing SWREG().

Ideally we'll port the driver away from the local registers, but for
now this is enough. For context - I was reading through the IRQ register
handling across the variants.

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: Ezequiel Garcia <ezequiel@collabora.com>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c b/drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c
index 6386a3989bfe..0fd306806f16 100644
--- a/drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c
+++ b/drivers/staging/media/hantro/hantro_g1_mpeg2_dec.c
@@ -10,6 +10,7 @@
 #include <media/v4l2-mem2mem.h>
 #include "hantro.h"
 #include "hantro_hw.h"
+#include "hantro_g1_regs.h"
 
 #define G1_SWREG(nr)			((nr) * 4)
 
@@ -20,7 +21,6 @@
 #define G1_REG_REFER2_BASE		G1_SWREG(16)
 #define G1_REG_REFER3_BASE		G1_SWREG(17)
 #define G1_REG_QTABLE_BASE		G1_SWREG(40)
-#define G1_REG_DEC_E(v)			((v) ? BIT(0) : 0)
 
 #define G1_REG_DEC_AXI_RD_ID(v)		(((v) << 24) & GENMASK(31, 24))
 #define G1_REG_DEC_TIMEOUT_E(v)		((v) ? BIT(23) : 0)
@@ -246,6 +246,5 @@ void hantro_g1_mpeg2_dec_run(struct hantro_ctx *ctx)
 
 	hantro_end_prepare_run(ctx);
 
-	reg = G1_REG_DEC_E(1);
-	vdpu_write(vpu, reg, G1_SWREG(1));
+	vdpu_write(vpu, G1_REG_INTERRUPT_DEC_E, G1_REG_INTERRUPT);
 }
-- 
2.31.1


  reply	other threads:[~2021-04-01 17:58 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-01 14:43 [PATCH v4 0/9] Microchip SAMA5D4 VPU support et al Emil Velikov
2021-04-01 14:43 ` Emil Velikov [this message]
2021-04-01 14:43 ` [PATCH v4 2/9] media: hantro: imx: reuse MB_DIM define Emil Velikov
2021-04-01 14:43 ` [PATCH v4 3/9] media: hantro: imx: remove duplicate dec_base init Emil Velikov
2021-04-01 14:43 ` [PATCH v4 4/9] media: hantro: imx: remove unused include Emil Velikov
2021-04-01 14:43 ` [PATCH v4 5/9] media: hantro: introduce hantro_g1.c for common API Emil Velikov
2021-04-01 14:43 ` [PATCH v4 6/9] media: hantro: add fallback handling for single irq/clk Emil Velikov
2021-04-01 14:43 ` [PATCH v4 7/9] media: dt-bindings: Document SAMA5D4 VDEC bindings Emil Velikov
2021-04-08 16:00   ` Rob Herring
2021-04-01 14:43 ` [PATCH v4 8/9] media: hantro: add initial SAMA5D4 support Emil Velikov
2021-04-01 14:43 ` [PATCH v4 9/9] ARM: dts: sama5d4: enable Hantro G1 VDEC Emil Velikov
2021-05-05 14:31   ` Hans Verkuil
2021-05-06 12:31     ` Emil Velikov
2021-05-06 12:35       ` Hans Verkuil
2021-04-14 10:32 ` [PATCH v4 0/9] Microchip SAMA5D4 VPU support et al Emil Velikov
2021-05-04 12:03   ` Emil Velikov
2021-05-04 12:49     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210401144336.2495479-2-emil.l.velikov@gmail.com \
    --to=emil.l.velikov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=ezequiel@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).