From: Rob Herring <robh@kernel.org>
To: Dmitry Osipenko <digetx@gmail.com>
Cc: devicetree@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] dt-bindings: memory: tegra20: emc: Convert to schema
Date: Thu, 1 Apr 2021 10:55:06 -0500 [thread overview]
Message-ID: <20210401155506.GA498681@robh.at.kernel.org> (raw)
In-Reply-To: <b4f7c7fb-1332-8490-fb4f-293fd357338e@gmail.com>
On Wed, Mar 31, 2021 at 05:59:39PM +0300, Dmitry Osipenko wrote:
> 31.03.2021 16:40, Rob Herring пишет:
> > On Wed, 31 Mar 2021 02:04:44 +0300, Dmitry Osipenko wrote:
> >> Convert Tegra20 External Memory Controller binding to schema.
> >>
> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> >> ---
> >> .../memory-controllers/nvidia,tegra20-emc.txt | 130 --------
> >> .../nvidia,tegra20-emc.yaml | 294 ++++++++++++++++++
> >> 2 files changed, 294 insertions(+), 130 deletions(-)
> >> delete mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.txt
> >> create mode 100644 Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.yaml
> >>
> >
> > My bot found errors running 'make dt_binding_check' on your patch:
> >
> > yamllint warnings/errors:
> >
> > dtschema/dtc warnings/errors:
> > Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-emc.example.dts:33.26-55.15: Warning (unit_address_vs_reg): /example-0/external-memory-controller@7000f400/emc-tables@0: node has a unit name, but no reg or ranges property
> >
> > See https://patchwork.ozlabs.org/patch/1460288
> >
> > This check can fail if there are any dependencies. The base for a patch
> > series is generally the most recent rc1.
> >
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >
> > pip3 install dtschema --upgrade
> >
> > Please check and re-submit.
> >
>
> FYI, I'm aware about this warning and I think it's fine to skip it in
> the case of this binding.
It's not because dt_binding_check should be warning free.
> The dtbs_check doesn't bother with that warning.
With W=1 it will. It's off by default because there are too many of
these warnings. Patches welcome.
Rob
next prev parent reply other threads:[~2021-04-01 17:44 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-30 23:04 [PATCH v2 0/6] NVIDIA Tegra memory improvements Dmitry Osipenko
2021-03-30 23:04 ` [PATCH v2 1/6] dt-bindings: memory: tegra20: emc: Replace core regulator with power domain Dmitry Osipenko
2021-03-30 23:04 ` [PATCH v2 2/6] dt-bindings: memory: tegra30: " Dmitry Osipenko
2021-04-01 17:17 ` Rob Herring
2021-03-30 23:04 ` [PATCH v2 3/6] dt-bindings: memory: tegra124: " Dmitry Osipenko
2021-04-01 17:17 ` Rob Herring
2021-03-30 23:04 ` [PATCH v2 4/6] dt-bindings: memory: tegra20: mc: Convert to schema Dmitry Osipenko
2021-04-01 17:18 ` Rob Herring
2021-03-30 23:04 ` [PATCH v2 5/6] dt-bindings: memory: tegra20: emc: " Dmitry Osipenko
2021-03-31 13:40 ` Rob Herring
2021-03-31 14:59 ` Dmitry Osipenko
2021-04-01 15:55 ` Rob Herring [this message]
2021-04-02 14:45 ` Dmitry Osipenko
2021-04-04 13:18 ` Dmitry Osipenko
2021-03-30 23:04 ` [PATCH v2 6/6] memory: tegra: Print out info-level once per driver probe Dmitry Osipenko
2021-04-01 17:50 ` [PATCH v2 0/6] NVIDIA Tegra memory improvements Krzysztof Kozlowski
2021-04-01 17:54 ` (subset) " Krzysztof Kozlowski
2021-04-01 17:54 ` Krzysztof Kozlowski
2021-04-02 14:47 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210401155506.GA498681@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=digetx@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).