From: Rob Herring <robh@kernel.org>
To: Flora Fu <flora.fu@mediatek.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Pi-Cheng Chen <pi-cheng.chen@mediatek.com>,
Chiawen Lee <chiawen.lee@mediatek.com>,
Chun-Jie Chen <chun-jie.chen@mediatek.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH 3/8] dt-bindings: apu: Add MT8192 APU power domain
Date: Fri, 9 Apr 2021 13:23:38 -0500 [thread overview]
Message-ID: <20210409182338.GA3895583@robh.at.kernel.org> (raw)
In-Reply-To: <1617766086-5502-4-git-send-email-flora.fu@mediatek.com>
On Wed, Apr 07, 2021 at 11:28:01AM +0800, Flora Fu wrote:
> Create MT8192 APU power domain bindings.
> Add top power domain id.
>
> Signed-off-by: Flora Fu <flora.fu@mediatek.com>
> ---
> include/dt-bindings/power/mt8192-apu-power.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 include/dt-bindings/power/mt8192-apu-power.h
>
> diff --git a/include/dt-bindings/power/mt8192-apu-power.h b/include/dt-bindings/power/mt8192-apu-power.h
> new file mode 100644
> index 000000000000..b821bd4811a6
> --- /dev/null
> +++ b/include/dt-bindings/power/mt8192-apu-power.h
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: GPL-2.0
> + *
> + * Copyright (c) 2021 MediaTek Inc.
> + */
> +
> +#ifndef _DT_BINDINGS_POWER_MT8192_APU_POWER_H
> +#define _DT_BINDINGS_POWER_MT8192_APU_POWER_H
> +
> +#define MT8192_POWER_DOMAIN_APUSYS_TOP 0
Really, you don't know what the other power domains are? Please make
this as complete as possible. These headers create a merge mess.
Rob
next prev parent reply other threads:[~2021-04-09 18:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-07 3:27 [PATCH 0/8] Add Support for MediaTek MT8192 APU Power Flora Fu
2021-04-07 3:27 ` [PATCH 1/8] dt-bindings: clock: Add MT8192 APU clock bindings Flora Fu
2021-04-09 18:09 ` Rob Herring
2021-04-07 3:28 ` [PATCH 2/8] clk: mediatek: mt8192: Add APU clocks support Flora Fu
2021-04-07 3:28 ` [PATCH 3/8] dt-bindings: apu: Add MT8192 APU power domain Flora Fu
2021-04-09 18:23 ` Rob Herring [this message]
2021-04-12 7:19 ` Flora Fu
2021-04-07 3:28 ` [PATCH 4/8] dt-bindings: arm: mediatek: Add new document bindings for APU Flora Fu
2021-04-09 18:25 ` Rob Herring
2021-04-12 6:44 ` Flora Fu
2021-04-15 21:24 ` Rob Herring
2021-04-16 3:01 ` Flora Fu
2021-04-07 3:28 ` [PATCH 5/8] dt-bindings: soc: mediatek: apusys: Add new document for APU power domain Flora Fu
2021-04-07 14:28 ` Rob Herring
2021-04-08 4:03 ` Flora Fu
2021-04-07 3:28 ` [PATCH 6/8] soc: mediatek: apu: Add apusys and add apu power domain driver Flora Fu
2021-04-07 3:28 ` [PATCH 7/8] arm64: dts: mt8192: Add APU node Flora Fu
2021-04-07 3:28 ` [PATCH 8/8] arm64: dts: mt8192: Add APU power domain node Flora Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210409182338.GA3895583@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=chiawen.lee@mediatek.com \
--cc=chun-jie.chen@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=flora.fu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=mturquette@baylibre.com \
--cc=pi-cheng.chen@mediatek.com \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).