devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Alex Elder <elder@linaro.org>
Cc: davem@davemloft.net, kuba@kernel.org, agross@kernel.org,
	bjorn.andersson@linaro.org, elder@kernel.org,
	linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings
Date: Mon, 12 Apr 2021 13:32:18 -0500	[thread overview]
Message-ID: <20210412183218.GA4164081@robh.at.kernel.org> (raw)
In-Reply-To: <20210409204024.1255938-2-elder@linaro.org>

On Fri, Apr 09, 2021 at 03:40:21PM -0500, Alex Elder wrote:
> Add existing supported platform "qcom,sc7180-ipa" to the set of IPA
> compatible strings.  Also add newly-supported "qcom,sdx55-ipa",
> "qcom,sc7280-ipa".
> 
> Signed-off-by: Alex Elder <elder@linaro.org>
> ---
>  Documentation/devicetree/bindings/net/qcom,ipa.yaml | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 8f86084bf12e9..2645a02cf19bf 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -43,7 +43,11 @@ description:
>  
>  properties:
>    compatible:
> -    const: "qcom,sdm845-ipa"
> +    oneOf:
> +      - const: "qcom,sc7180-ipa"
> +      - const: "qcom,sc7280-ipa"
> +      - const: "qcom,sdm845-ipa"
> +      - const: "qcom,sdx55-ipa"

Use enum instead of oneOf + const. And drop the quotes.

>  
>    reg:
>      items:
> -- 
> 2.27.0
> 

  reply	other threads:[~2021-04-12 18:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-09 20:40 [PATCH net-next 0/4] net: ipa: support two more platforms Alex Elder
2021-04-09 20:40 ` [PATCH net-next 1/4] dt-bindings: net: qcom,ipa: add some compatible strings Alex Elder
2021-04-12 18:32   ` Rob Herring [this message]
2021-04-09 20:40 ` [PATCH net-next 2/4] net: ipa: disable checksum offload for IPA v4.5+ Alex Elder
2021-04-09 20:40 ` [PATCH net-next 3/4] net: ipa: add IPA v4.5 configuration data Alex Elder
2021-04-09 20:40 ` [PATCH net-next 4/4] net: ipa: add IPA v4.11 " Alex Elder
2021-04-12  0:10 ` [PATCH net-next 0/4] net: ipa: support two more platforms patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210412183218.GA4164081@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=elder@kernel.org \
    --cc=elder@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).