From: Rob Herring <robh@kernel.org>
To: Nishanth Menon <nm@ti.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
s-anna@ti.com, linux-kernel@vger.kernel.org,
Jassi Brar <jassisinghbrar@gmail.com>
Subject: Re: [PATCH V3] dt-bindings: mailbox: ti, secure-proxy: Convert to json schema
Date: Fri, 16 Apr 2021 14:12:54 -0500 [thread overview]
Message-ID: <20210416191254.GA3779553@robh.at.kernel.org> (raw)
In-Reply-To: <20210416005953.17147-1-nm@ti.com>
On Thu, 15 Apr 2021 19:59:53 -0500, Nishanth Menon wrote:
> Convert the ti,secure-proxy to yaml for better checks and documentation.
> Differences being mostly in the examples:
> - Dropped the example usage of mailbox client, it is better done in
> tisci node definition.
> - Switched reg usage for address-cells and size-cells 1 - aligned with
> schema checks as well.
> - included header in example for a buildable example.
>
> While at this, lets make sure to support upto 100 rx threads even though
> typically upto 1 threads is practically in use.
>
> NOTE: The following checkpatch warning is generated since we do include the header
> in the example, but this is a false positive warning.
> WARNING: DT binding docs and includes should be a separate patch. See:
> Documentation/devicetree/bindings/submitting-patches.rst
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
>
> Changes since v2:
> - Subject line rewording to indicate json schema rather than yaml
> - Review comment: Dropped "-" in interrupt-names pattern so that it will match all
> entries
> - Minor commit message formatting changes
>
> V2: https://lore.kernel.org/linux-arm-kernel/20210413224535.30910-1-nm@ti.com/
> V1: https://lore.kernel.org/linux-arm-kernel/20210413171230.5872-1-nm@ti.com/
>
> .../bindings/mailbox/ti,secure-proxy.txt | 50 ------------
> .../bindings/mailbox/ti,secure-proxy.yaml | 79 +++++++++++++++++++
> 2 files changed, 79 insertions(+), 50 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.txt
> create mode 100644 Documentation/devicetree/bindings/mailbox/ti,secure-proxy.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
prev parent reply other threads:[~2021-04-16 19:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 0:59 [PATCH V3] dt-bindings: mailbox: ti,secure-proxy: Convert to json schema Nishanth Menon
2021-04-16 19:12 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210416191254.GA3779553@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=s-anna@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).