From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5064C433B4 for ; Sat, 17 Apr 2021 12:51:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B78A9611C2 for ; Sat, 17 Apr 2021 12:51:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236396AbhDQMwI (ORCPT ); Sat, 17 Apr 2021 08:52:08 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:33132 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230442AbhDQMwI (ORCPT ); Sat, 17 Apr 2021 08:52:08 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 13HCpSoT004245; Sat, 17 Apr 2021 07:51:28 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1618663888; bh=rPXmuMzpEkCL6BgxZC9XuLSBLEjAY7E3u9qrT0/yQqc=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=kAx7E1taPPjvq1bWp4ngK6qZvJmDfictdiLPahQmUKHBB7csyL3OakYz8Picpcv3F 2f7zcIvSyMlk43qJ4TnW8CmgstcyeCQYqXCbqwkxLopA8c1/9e73RY6mEMTbYfoJGM xvhOJpiEqsLTRfSWZI7yyJ8tQRg/jiQpy8cSy+3Y= Received: from DLEE105.ent.ti.com (dlee105.ent.ti.com [157.170.170.35]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 13HCpSWQ023901 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 17 Apr 2021 07:51:28 -0500 Received: from DLEE106.ent.ti.com (157.170.170.36) by DLEE105.ent.ti.com (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Sat, 17 Apr 2021 07:51:27 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Sat, 17 Apr 2021 07:51:27 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 13HCpRJL053600; Sat, 17 Apr 2021 07:51:27 -0500 Date: Sat, 17 Apr 2021 07:51:27 -0500 From: Nishanth Menon To: Stephen Boyd CC: Michael Turquette , Philipp Zabel , Rob Herring , Santosh Shilimkar , Tero Kristo , , , , Subject: Re: [PATCH 2/4] dt-bindings: clock: Convert ti,sci-clk to json schema Message-ID: <20210417125127.vigq23mdoodje6b5@velcro> References: <20210416063721.20538-1-nm@ti.com> <20210416063721.20538-3-nm@ti.com> <161861731160.46595.786611690053722257@swboyd.mtv.corp.google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <161861731160.46595.786611690053722257@swboyd.mtv.corp.google.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 16:55-20210416, Stephen Boyd wrote: > Quoting Nishanth Menon (2021-04-15 23:37:19) > > diff --git a/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml > > new file mode 100644 > > index 000000000000..72633651f0c7 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/clock/ti,sci-clk.yaml > > @@ -0,0 +1,52 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/clock/ti,sci-clk.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: TI-SCI clock controller node bindings > > + > > +maintainers: > > + - Nishanth Menon > > + > > +allOf: > > + - $ref: /schemas/clock/clock.yaml# > > Is this needed? https://github.com/devicetree-org/dt-schema/blob/master/schemas/clock/clock.yaml This standardizes provider properties like '#clock-cells' etc, allowing you to add more stricter checks or controls in the future if necessary. while: https://github.com/devicetree-org/dt-schema/blob/master/meta-schemas/clocks.yaml is more a consumer node description. Should I have picked a different yaml as base for a standard clock-controller base? > > > + > > +description: | > > + Some TI SoCs contain a system controller (like the Power Management Micro > > + Controller (PMMC) on Keystone 66AK2G SoC) that are responsible for controlling > > + the state of the various hardware modules present on the SoC. Communication > > + between the host processor running an OS and the system controller happens > > + through a protocol called TI System Control Interface (TI-SCI protocol). > > + > > + This clock controller node uses the TI SCI protocol to perform various clock > > + management of various hardware modules (devices) present on the SoC. This > > + node must be a child node of the associated TI-SCI system controller node. > > + > > +properties: > > + $nodename: > > + pattern: "^clock-controller$" > > Is this nodename pattern check required? I'd like the definition on rails and not subject to interpretation, and restrict the kind of subnodes under TISCI controller node. > > > + > > + compatible: > > + const: ti,k2g-sci-clk > > I thought most things keyed off the compatible string. Yes, they are. I am not sure I understand your question here. Did you mean to indicate that having $nodename and compatible both are redundant? Redundancy was'nt the intent of this schema definition, rather, I'd like to make sure that it is not upto interpretation or debate as to what the node name should be: I believe clock-controller is the correct nodename (without @0x... since this does'nt use reg property) instead of using clocks, tisci-clock as the node names. Do you suggest something different? -- Regards, Nishanth Menon Key (0xDDB5849D1736249D)/Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D