Re: [PATCH v4 4/7] dt-bindings: cpufreq: cpufreq-qcom-hw: Convert to YAML bindings

Bjorn Andersson
2021-04-19T19:17:55Z

On Tue 19 Jan 11:45 CST 2021, AngeloGioacchino Del Regno wrote:
[..]
> diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> new file mode 100644
> index 000000000000..bc81b6203e27
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-qcom-hw.yaml
> @@ -0,0 +1,204 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/cpufreq/cpufreq-qcom-hw.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm Technologies, Inc. CPUFREQ
> +
> +maintainers:
> + - Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
> +

Mani, I presume you're still up for the maintainership of this binding?

> +description: |
> +
> + CPUFREQ HW is a hardware engine used by some Qualcomm Technologies, Inc. (QTI)
> + SoCs to manage frequency in hardware. It is capable of controlling frequency
> + for multiple clusters.
[..]
> +
> +required:
> + - compatible
> + - reg
> + - reg-names

This is optional in the .txt version and as such I would like you to
make this required in a separate patch following the yaml conversion.

Apart from that I think this looks good.

> + - clocks
> + - clock-names
> + - '#freq-domain-cells'
> +

Regards,
Bjorn