Re: [PATCH V2] dt-bindings: clock: brcm,iproc-clocks: convert to the json-schema

[Rob Herring <robh@kernel.org>]

On Wed, Apr 21, 2021 at 06:56:33PM +0200, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> This helps validating DTS files.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> V2: Fix typo s/clocks/clock-output-names/
> ---
>  .../bindings/clock/brcm,iproc-clocks.txt      | 313 --------------
>  .../bindings/clock/brcm,iproc-clocks.yaml     | 398 ++++++++++++++++++
>  2 files changed, 398 insertions(+), 313 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/clock/brcm,iproc-clocks.txt
>  create mode 100644 Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml


> diff --git a/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml
> new file mode 100644
> index 000000000000..a1b9613f7c68
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/brcm,iproc-clocks.yaml
> @@ -0,0 +1,398 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/clock/brcm,iproc-clocks.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom iProc Family Clocks
> +
> +maintainers:
> +  - Ray Jui <rjui@broadcom.com>
> +  - Scott Branden <sbranden@broadcom.com>
> +
> +description: |
> +  This binding uses the common clock binding:
> +      Documentation/devicetree/bindings/clock/clock-bindings.txt

I think we can drop this statement.

> +
> +  The iProc clock controller manages clocks that are common to the iProc family.
> +  An SoC from the iProc family may have several PPLs, e.g., ARMPLL, GENPLL,

s/PPLs/PLLs/

Otherwise,

Reviewed-by: Rob Herring <robh@kernel.org>