devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Sean Nyekjaer <sean@geanix.com>
Cc: <jic23@kernel.org>, <linux-iio@vger.kernel.org>,
	<andy.shevchenko@gmail.com>, <lars@metafoo.de>,
	<Nuno.Sa@analog.com>, <robh+dt@kernel.org>,
	<devicetree@vger.kernel.org>
Subject: Re: [RFC PATCH 3/4] iio: accel: fxls8962af: add hw buffered sampling
Date: Thu, 29 Apr 2021 15:52:17 +0100	[thread overview]
Message-ID: <20210429155217.00006a34@Huawei.com> (raw)
In-Reply-To: <f679124a-4efc-c98d-49ec-dd294fe44b5a@geanix.com>

On Thu, 29 Apr 2021 09:40:00 +0200
Sean Nyekjaer <sean@geanix.com> wrote:

> On 28/04/2021 18.32, Jonathan Cameron wrote:
> >> When buffered sampling is enabled, the accelerometer will dump data into
> >> the internal fifo and interrupt at watermark. Then the driver flushes
> >> all data to the iio buffer.
> >> As the accelerometer doesn't have internal timestamps, they are aproximated
> >> between to interrupts.  
> > two?
> >
> > This tends to be a noisy approach, so people often try to apply a filter.
> > However, no need to do that for an initial version.
> >
> > There are some things in here referring to enabling triggered modes, but I'm
> > not seeing code to actually do so.  The fun question when dealing with fifos
> > and triggered mode is what the interface is to switch between the two.
> > One option I think we've used before is to just have 'no trigger' match
> > up to fifo mode and if a trigger is set, don't use the fifo.
> >  
> Thanks Jonathan.
> 
> Fixed the above text to:
> As the accelerometer doesn't have internal timestamps,
> they are approximated between the current and last interrupt.
Nice.

> 
> I don't know the correct term here, the accelerometer via the watermark, 
> is doing interrupts.
> Is that called no-trigger / trigger ?

Triggers are one per scan (Set of samples take at approximately the same time)
So anything involving a fifo is without trigger (we don't expose anything because
it is of no use for doing synchronous capture across multiple devices).

One day I'll add a terminology section to the docs!

J

> 
> /Sean


  reply	other threads:[~2021-04-29 14:53 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-28  8:22 [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Sean Nyekjaer
2021-04-28  8:22 ` [RFC PATCH 2/4] iio: accel: fxls8962af: add interrupt support Sean Nyekjaer
2021-04-28 14:26   ` Jonathan Cameron
2021-04-29  8:58   ` Lars-Peter Clausen
2021-04-29  9:35     ` Andy Shevchenko
2021-04-29  9:37       ` Lars-Peter Clausen
2021-04-29 11:35         ` Andy Shevchenko
2021-04-29 19:19           ` Lars-Peter Clausen
2021-04-30  8:54             ` Andy Shevchenko
2021-04-28  8:22 ` [RFC PATCH 3/4] iio: accel: fxls8962af: add hw buffered sampling Sean Nyekjaer
2021-04-28 11:05   ` Sean Nyekjaer
2021-04-28 13:53     ` Jonathan Cameron
2021-04-28 16:32   ` Jonathan Cameron
2021-04-29  7:40     ` Sean Nyekjaer
2021-04-29 14:52       ` Jonathan Cameron [this message]
2021-04-28  8:22 ` [RFC PATCH 4/4] iio: accel: fxls8962af: fix errata bug E3 - I2C burst reads Sean Nyekjaer
2021-04-28 11:24   ` Andy Shevchenko
2021-04-28 11:37     ` Sean Nyekjaer
2021-04-28 13:56 ` [RFC PATCH 1/4] dt-bindings: iio: accel: fxls8962af: add interrupt options Jonathan Cameron
2021-05-03 19:21 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210429155217.00006a34@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Nuno.Sa@analog.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=sean@geanix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).