Re: [PATCH] dt-binding: interrupt-controller: Add missing interrupts property

Thomas Bogendoerfer
2021-04-28T22:42:35Z

On Wed, Apr 28, 2021 at 05:15:09PM -0500, Rob Herring wrote:
> On Wed, 28 Apr 2021 00:42:00 +0200, Thomas Bogendoerfer wrote:
> > Interrupts property is required, so add it.
> >
> > Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> > ---
> > .../bindings/interrupt-controller/idt,32434-pic.yaml | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.example.dt.yaml: interrupt-controller@1c20400: 'oneOf' conditional failed, one must be fixed:
> 'interrupts' is a required property
> 'interrupts-extended' is a required property
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun4i-a10-ic.yaml

now I'm confused... is this a problem of your test ? make dt_binding_check
was ok with that change...

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]