From: Rob Herring <robh@kernel.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-spi@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Serge Semin <fancer.lancer@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
Gareth Williams <gareth.williams.jx@renesas.com>
Subject: Re: [PATCH] dt-bindings: spi: dw-apb-ssi: Integrate Renesas RZ/N1 SPI controller
Date: Fri, 7 May 2021 17:13:50 -0500 [thread overview]
Message-ID: <20210507221350.GA2990934@robh.at.kernel.org> (raw)
In-Reply-To: <aef15aa119ed02487ded4691141678bc1040c3b4.1620301936.git.geert+renesas@glider.be>
On Thu, 06 May 2021 13:52:59 +0200, Geert Uytterhoeven wrote:
> Originally, the Renesas RZ/N1 SPI Controller DT bindings were not
> integrated in the main DT bindings for the Synopsys DesignWare
> Synchronous Serial Interface, but in its own file, as the RZ/N1
> controller has additional registers for software CS control and DMA.
>
> As so far DMA is not supported on RZ/N1, and json-schema can handle any
> possible differences fine, integrate the RZ/N1 compatible values in the
> main DT bindings for the Synopsys DW SSI.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> There are no upstream users of this binding, but it validates the
> following (modified) example taken from the RZ/N1 BSP[1] fine:
>
> spi0: spi@50005000 {
> compatible = "renesas,r9a06g032-spi", "renesas,rzn1-spi";
> reg = <0x50005000 0x400>;
> interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> clock-names = "ssi_clk", "pclk";
> clocks = <&sysctrl R9A06G032_CLK_SPI0>, <&sysctrl R9A06G032_HCLK_SPI0>;
> #address-cells = <1>;
> #size-cells = <0>;
> spi-max-frequency = <12500000>;
> num-cs = <4>;
> };
>
> [1] https://github.com/renesas-rz/rzn1_linux/blob/rzn1-stable-v4.19/arch/arm/boot/dts/rzn1.dtsi
> ---
> .../devicetree/bindings/spi/renesas,rzn1-spi.txt | 11 -----------
> .../devicetree/bindings/spi/snps,dw-apb-ssi.yaml | 6 ++++++
> 2 files changed, 6 insertions(+), 11 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/spi/renesas,rzn1-spi.txt
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2021-05-07 22:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-06 11:52 [PATCH] dt-bindings: spi: dw-apb-ssi: Integrate Renesas RZ/N1 SPI controller Geert Uytterhoeven
2021-05-07 22:13 ` Rob Herring [this message]
2021-05-11 8:25 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210507221350.GA2990934@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=fancer.lancer@gmail.com \
--cc=gareth.williams.jx@renesas.com \
--cc=geert+renesas@glider.be \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).