From: "Ondřej Jirman" <megous@megous.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Stephan Gerhold <stephan@gerhold.net>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org,
Simon Budig <simon.budig@kernelconcepts.de>,
Marco Felsch <m.felsch@pengutronix.de>
Subject: Re: [PATCH v2 2/2] Input: edt-ft5x06 - add support for iovcc-supply
Date: Mon, 10 May 2021 22:17:51 +0200 [thread overview]
Message-ID: <20210510201751.xs5lq5a3kcvp5fpq@core> (raw)
In-Reply-To: <YJmS9NqGFGem6gxg@smile.fi.intel.com>
On Mon, May 10, 2021 at 11:09:24PM +0300, Andy Shevchenko wrote:
> On Mon, May 10, 2021 at 09:48:48PM +0200, Ondřej Jirman wrote:
> > On Mon, May 10, 2021 at 09:31:08PM +0200, Stephan Gerhold wrote:
>
> > > + tsdata->iovcc = devm_regulator_get(&client->dev, "iovcc");
> > > + if (IS_ERR(tsdata->iovcc)) {
> > > + error = PTR_ERR(tsdata->iovcc);
> > > + if (error != -EPROBE_DEFER)
> > > + dev_err(&client->dev,
> > > + "failed to request iovcc regulator: %d\n", error);
> >
> > Please use dev_err_probe instead. If this pattern is used for vcc-supply, maybe
> > change that too. Maybe also consider using a bulk regulator API.
>
> Dmitry seems is having something against it last time I remember it was
> discussed with him.
It basically does the same thing this does, except that you can figure out
the failure later on from sysfs more easily just by looking at:
/sys/kernel/debug/devices_deferred
And you'll see the error message there to help you figure out the dependency
that failed. What's to hate about this? :)
kind regards,
o.
> --
> With Best Regards,
> Andy Shevchenko
>
>
next prev parent reply other threads:[~2021-05-10 20:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-10 19:31 [PATCH v2 1/2] dt-bindings: input: touchscreen: edt-ft5x06: add iovcc-supply Stephan Gerhold
2021-05-10 19:31 ` [PATCH v2 2/2] Input: edt-ft5x06 - add support for iovcc-supply Stephan Gerhold
2021-05-10 19:48 ` Ondřej Jirman
2021-05-10 20:09 ` Andy Shevchenko
2021-05-10 20:17 ` Ondřej Jirman [this message]
2021-05-10 20:16 ` Stephan Gerhold
2021-05-10 21:14 ` Ondřej Jirman
2021-05-11 7:21 ` Andy Shevchenko
2021-05-11 7:42 ` Marco Felsch
2021-05-11 8:50 ` Stephan Gerhold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210510201751.xs5lq5a3kcvp5fpq@core \
--to=megous@megous.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=simon.budig@kernelconcepts.de \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox