From: Boris Lysov <arzamas-16@mail.ee>
To: Guenter Roeck <linux@roeck-us.net>
Cc: matthias.bgg@gmail.com, robh+dt@kernel.org,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 1/3] watchdog: mtk_wdt: Refactor code to support more SoCs
Date: Tue, 11 May 2021 01:27:42 +0300 [thread overview]
Message-ID: <20210511012742.569b63f7@pc> (raw)
In-Reply-To: <efdce3a5-e5b4-19a8-35f1-8a536220bb3f@roeck-us.net>
Hello,
On Mon, 10 May 2021 06:21:54 -0700
Guenter Roeck <linux@roeck-us.net> wrote:
> > - struct mtk_wdt_dev *data =
> > + struct mtk_wdt_dev *wdev =
>
> Please do not rename variables. If you dislike that the name matches the name
> of the newly introduced structure element, find a different name for that.
I will fix it in v3.
next prev parent reply other threads:[~2021-05-10 22:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-31 23:44 [PATCH 0/3] watchdog: mtk_wdt: add support for mt6577 Boris Lysov
2021-01-31 23:44 ` [PATCH 1/3] dt-bindings: watchdog: mediatek: add support for mt6577 SoC Boris Lysov
2021-02-09 20:41 ` Rob Herring
2021-01-31 23:44 ` [PATCH 2/3] watchdog: mtk_wdt: add support for 16-bit control registers Boris Lysov
2021-02-01 0:31 ` Guenter Roeck
2021-02-02 1:33 ` Boris Lysov
2021-02-02 1:55 ` Guenter Roeck
2021-02-10 11:37 ` Matthias Brugger
2021-01-31 23:44 ` [PATCH 3/3] watchdog: mtk_wdt: declare compatibility with mt6577 Boris Lysov
2021-05-09 21:16 ` [PATCH v2 0/3] watchdog: mtk_wdt: refactor code to support more watchdogs Boris Lysov
2021-05-09 21:17 ` [PATCH v2 1/3] watchdog: mtk_wdt: Refactor code to support more SoCs Boris Lysov
2021-05-10 13:21 ` Guenter Roeck
2021-05-10 22:27 ` Boris Lysov [this message]
2021-05-09 21:17 ` [PATCH v2 2/3] dt-bindings: watchdog: mediatek: add support for mt6577 SoC Boris Lysov
2021-05-10 16:17 ` Rob Herring
2021-05-09 21:17 ` [PATCH v2 3/3] watchdog: mtk_wdt: add support for mt6577 Boris Lysov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511012742.569b63f7@pc \
--to=arzamas-16@mail.ee \
--cc=devicetree@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).