From: Rui Miguel Silva <rui.silva@linaro.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sebastian Siewior <bigeasy@linutronix.de>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Rob Herring <robh+dt@kernel.org>
Cc: linux-usb@vger.kernel.org, devicetree@vger.kernel.org,
Rui Miguel Silva <rui.silva@linaro.org>
Subject: [PATCH v2 4/9] usb: isp1760: remove platform data struct and code
Date: Tue, 11 May 2021 09:50:56 +0100 [thread overview]
Message-ID: <20210511085101.2081399-5-rui.silva@linaro.org> (raw)
In-Reply-To: <20210511085101.2081399-1-rui.silva@linaro.org>
Since the removal of the Blackfin port with:
commit 4ba66a976072 ("arch: remove blackfin port")
No one is using or referencing this header and platform data struct.
Remove them.
Signed-off-by: Rui Miguel Silva <rui.silva@linaro.org>
---
drivers/usb/isp1760/isp1760-if.c | 20 +++-----------------
include/linux/usb/isp1760.h | 19 -------------------
2 files changed, 3 insertions(+), 36 deletions(-)
delete mode 100644 include/linux/usb/isp1760.h
diff --git a/drivers/usb/isp1760/isp1760-if.c b/drivers/usb/isp1760/isp1760-if.c
index abfba9f5ec23..fb6701608cd8 100644
--- a/drivers/usb/isp1760/isp1760-if.c
+++ b/drivers/usb/isp1760/isp1760-if.c
@@ -16,7 +16,6 @@
#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/slab.h>
-#include <linux/usb/isp1760.h>
#include <linux/usb/hcd.h>
#include "isp1760-core.h"
@@ -225,22 +224,9 @@ static int isp1760_plat_probe(struct platform_device *pdev)
if (of_property_read_bool(dp, "dreq-polarity"))
devflags |= ISP1760_FLAG_DREQ_POL_HIGH;
- } else if (dev_get_platdata(&pdev->dev)) {
- struct isp1760_platform_data *pdata =
- dev_get_platdata(&pdev->dev);
-
- if (pdata->is_isp1761)
- devflags |= ISP1760_FLAG_ISP1761;
- if (pdata->bus_width_16)
- devflags |= ISP1760_FLAG_BUS_WIDTH_16;
- if (pdata->port1_otg)
- devflags |= ISP1760_FLAG_OTG_EN;
- if (pdata->analog_oc)
- devflags |= ISP1760_FLAG_ANALOG_OC;
- if (pdata->dack_polarity_high)
- devflags |= ISP1760_FLAG_DACK_POL_HIGH;
- if (pdata->dreq_polarity_high)
- devflags |= ISP1760_FLAG_DREQ_POL_HIGH;
+ } else {
+ pr_err("isp1760: no platform data\n");
+ return -ENXIO;
}
ret = isp1760_register(mem_res, irq_res->start, irqflags, &pdev->dev,
diff --git a/include/linux/usb/isp1760.h b/include/linux/usb/isp1760.h
deleted file mode 100644
index b75ded28db81..000000000000
--- a/include/linux/usb/isp1760.h
+++ /dev/null
@@ -1,19 +0,0 @@
-/* SPDX-License-Identifier: GPL-2.0 */
-/*
- * board initialization should put one of these into dev->platform_data
- * and place the isp1760 onto platform_bus named "isp1760-hcd".
- */
-
-#ifndef __LINUX_USB_ISP1760_H
-#define __LINUX_USB_ISP1760_H
-
-struct isp1760_platform_data {
- unsigned is_isp1761:1; /* Chip is ISP1761 */
- unsigned bus_width_16:1; /* 16/32-bit data bus width */
- unsigned port1_otg:1; /* Port 1 supports OTG */
- unsigned analog_oc:1; /* Analog overcurrent */
- unsigned dack_polarity_high:1; /* DACK active high */
- unsigned dreq_polarity_high:1; /* DREQ active high */
-};
-
-#endif /* __LINUX_USB_ISP1760_H */
--
2.31.1
next prev parent reply other threads:[~2021-05-11 8:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 8:50 [PATCH v2 0/9] usb: isp1760: extend support for isp1763 Rui Miguel Silva
2021-05-11 8:50 ` [PATCH v2 1/9] usb: isp1760: fix strict typechecking Rui Miguel Silva
2021-05-11 8:50 ` [PATCH v2 2/9] usb: isp1760: move to regmap for register access Rui Miguel Silva
2021-05-11 8:50 ` [PATCH v2 3/9] usb: isp1760: use relaxed primitives Rui Miguel Silva
2021-05-11 8:50 ` Rui Miguel Silva [this message]
2021-05-11 8:50 ` [PATCH v2 5/9] usb: isp1760: hcd: refactor mempool config and setup Rui Miguel Silva
2021-05-11 8:50 ` [PATCH v2 6/9] usb: isp1760: use dr_mode binding Rui Miguel Silva
2021-05-11 8:50 ` [PATCH v2 7/9] usb: isp1760: add support for isp1763 Rui Miguel Silva
2021-05-11 8:51 ` [PATCH v2 8/9] dt-bindings: usb: nxp,isp1760: add bindings Rui Miguel Silva
2021-05-11 19:22 ` Rob Herring
2021-05-13 8:38 ` Rui Miguel Silva
2021-05-11 8:51 ` [PATCH v2 9/9] usb: isp1763: add peripheral mode Rui Miguel Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210511085101.2081399-5-rui.silva@linaro.org \
--to=rui.silva@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-usb@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).