devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Eugen.Hristev@microchip.com
Cc: alexandre.belloni@bootlin.com, Nicolas.Ferre@microchip.com,
	Ludovic.Desroches@microchip.com, soc@kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Claudiu.Beznea@microchip.com,
	Codrin.Ciubotariu@microchip.com
Subject: Re: [PATCH v2 2/4] ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek
Date: Tue, 11 May 2021 14:16:53 -0500	[thread overview]
Message-ID: <20210511191653.GA2446068@robh.at.kernel.org> (raw)
In-Reply-To: <8c74596c-6d23-c822-fc2e-6cbb984fa4fd@microchip.com>

On Tue, May 11, 2021 at 09:03:37AM +0000, Eugen.Hristev@microchip.com wrote:
> On 5/11/21 10:37 AM, Alexandre Belloni wrote:
> > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> > 
> > On 11/05/2021 07:18:31+0000, Eugen.Hristev@microchip.com wrote:
> >> On 5/11/21 10:12 AM, Eugen Hristev wrote:
> >>> Add Device Tree for sama7g5 SoC and associated board sama7g5-ek
> >>>
> >>> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> >>> [claudiu.beznea@microchip.com: add clocks, ethernet, timers, power]
> >>> Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
> >>> [codrin.ciubotariu@microchip.com: add audio]
> >>> Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>
> >>> ---
> >>
> >> Changes in v2:
> >> - fixed license
> >> - fixed warnings for make dtbs (changed ahb/apb to just soc)
> >> - changed some node names as suggested
> >> - removed some okay status properties
> >> - addressed cpu node by label
> >> - removed stdout path
> > 
> > Why would you remove stdout-path? The solution was to remove The console
> > parameter from bootargs, especially since you don't know what name the
> > console device will have depending on CONFIG_SERIAL_ATMEL_TTYAT.
> 
> Ok, sure, I will add it back and remove console=...
> 
> I will wait to see if Rob has anymore comments before preparing a v3.

No, nothing else.

  reply	other threads:[~2021-05-12 20:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  7:12 [PATCH v2 1/4] dt-bindings: ARM: at91: document sama7g5ek board Eugen Hristev
2021-05-11  7:12 ` [PATCH v2 2/4] ARM: dts: at91: add sama7g5 SoC DT and sama7g5-ek Eugen Hristev
2021-05-11  7:18   ` Eugen.Hristev
2021-05-11  7:37     ` Alexandre Belloni
2021-05-11  9:03       ` Eugen.Hristev
2021-05-11 19:16         ` Rob Herring [this message]
2021-05-25  9:25           ` Nicolas Ferre
2021-05-11  7:12 ` [PATCH v2 3/4] ARM: configs: at91: add defconfig for sama7 family of SoCs Eugen Hristev
2021-05-11  7:12 ` [PATCH v2 4/4] ARM: multi_v7_defconfig: add sama7g5 SoC Eugen Hristev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210511191653.GA2446068@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=Claudiu.Beznea@microchip.com \
    --cc=Codrin.Ciubotariu@microchip.com \
    --cc=Eugen.Hristev@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=Nicolas.Ferre@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=soc@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).