From: Shawn Guo <shawnguo@kernel.org>
To: Mian Yousaf Kaukab <ykaukab@suse.de>
Cc: leoyang.li@nxp.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node
Date: Thu, 13 May 2021 15:59:17 +0800 [thread overview]
Message-ID: <20210513075917.GX3425@dragon> (raw)
In-Reply-To: <20210428125807.29553-1-ykaukab@suse.de>
On Wed, Apr 28, 2021 at 02:58:07PM +0200, Mian Yousaf Kaukab wrote:
> On LS2088A-RDB board, if the spi-fsl-dspi driver is built as module
> then its probe fails with the following warning:
>
> [ 10.471363] couldn't get idr
> [ 10.471381] WARNING: CPU: 4 PID: 488 at drivers/spi/spi.c:2689 spi_register_controller+0x73c/0x8d0
> ...
> [ 10.471651] fsl-dspi 2100000.spi: Problem registering DSPI ctlr
> [ 10.471708] fsl-dspi: probe of 2100000.spi failed with error -16
>
> Reason for the failure is that bus-num property is set for dspi node.
> However, bus-num property is not set for the qspi node. If probe for
> spi-fsl-qspi happens first then id 0 is dynamically allocated to it.
> Call to spi_register_controller() from spi-fsl-dspi driver then fails.
> Since commit 29d2daf2c33c ("spi: spi-fsl-dspi: Make bus-num property
> optional") bus-num property is optional. Remove bus-num property from
> dspi node to fix the issue.
>
> Signed-off-by: Mian Yousaf Kaukab <ykaukab@suse.de>
Applied, thanks.
prev parent reply other threads:[~2021-05-13 7:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-28 12:58 [PATCH] arm64: dts: ls208xa: remove bus-num from dspi node Mian Yousaf Kaukab
2021-05-13 7:59 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210513075917.GX3425@dragon \
--to=shawnguo@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=ykaukab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).