devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nishanth Menon <nm@ti.com>
To: Suman Anna <s-anna@ti.com>
Cc: Jan Kiszka <jan.kiszka@siemens.com>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes
Date: Fri, 14 May 2021 17:15:15 -0500	[thread overview]
Message-ID: <20210514221515.lxsdk5j764eim6m5@explode> (raw)
In-Reply-To: <20210514212016.3153-1-s-anna@ti.com>

On 16:20-20210514, Suman Anna wrote:
> There are no sub-mailbox devices defined currently for both the
> IOT2050 boards. These are usually dictated by the firmwares running
> on the R5F remote processors and the applications they provide.
> Defining the actual sub-mailboxes will also dictate the interrupts
> the clusters will use for interrupts on the Cortex-A53 cores.
> 
> Disable all of the Mailbox clusters until the sub-mailboxes are
> defined and used. This fixes the warnings around the missing
> interrupts with the upcoming conversion of the OMAP Mailbox binding
> to YAML format.
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> Hi Nishanth,
> 
> I will be posting the conversion of the OMAP Mailbox binding to YAML
> sometime next week to deal with the current dtbs_check warnings seen
> with these nodes on all K3 SoCs. It is kinda of a chicken and egg
> problem w.r.t when you want all warnings gone, and this is in
> preparation towards that. It also follows anyway the expected style
> for Mailbox unless you add the usable mailbox sub-device nodes and
> the interrupts they use.
> 

yes, that was the exact intent of pushing to cleanup our yaml to expose
definition issues such as these.. Glad and thanks you are doing this.

Expectation ofcourse is that we get the dts fixups done and merged asap
so that the yaml conversion merges produce a clean dtbs_check - where
ever possible hopefully by 5.14-rc1 (I know it is a tall order given the
scope of conversion pending - but bite at a time).

Jan: Are you OK with this? I think overlays will help introduce the
variations you need with the firmware if there is any.

>  .../boot/dts/ti/k3-am65-iot2050-common.dtsi   | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> index de763ca9251c..f4ec9ed52939 100644
> --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> @@ -653,3 +653,51 @@ &pcie1_rc {
>  &pcie1_ep {
>  	status = "disabled";
>  };
> +
> +&mailbox0_cluster0 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster1 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster2 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster3 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster4 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster5 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster6 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster7 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster8 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster9 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster10 {
> +	status = "disabled";
> +};
> +
> +&mailbox0_cluster11 {
> +	status = "disabled";
> +};
> -- 
> 2.30.1
> 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D

  reply	other threads:[~2021-05-14 22:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-14 21:20 [PATCH] arm64: dts: ti: k3-am65-iot2050-common: Disable mailbox nodes Suman Anna
2021-05-14 22:15 ` Nishanth Menon [this message]
2021-05-19 16:50 ` Jan Kiszka
2021-05-22  0:54 ` Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210514221515.lxsdk5j764eim6m5@explode \
    --to=nm@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=s-anna@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).