From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-22.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A367C433ED for ; Mon, 17 May 2021 14:08:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DBA4F613DD for ; Mon, 17 May 2021 14:08:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237922AbhEQOI7 (ORCPT ); Mon, 17 May 2021 10:08:59 -0400 Received: from fllv0015.ext.ti.com ([198.47.19.141]:52552 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237925AbhEQOGn (ORCPT ); Mon, 17 May 2021 10:06:43 -0400 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 14HE5KFh090728; Mon, 17 May 2021 09:05:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1621260320; bh=kmaEG3lVRhUTp1BUJ0Ejv46ZvX4BgEHKo5jIPbz7/zM=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=jBsRh8dgEjJ0OCSw/1Gz+jB4zTpNJHpbXefLM9v2Iib0B4UShhZYVQZLoFIbx+R8q Q1ECV6uPL9r/sPX1tK1TvNkBEcHr3OBBw1OV/CUOWcchL9TDmzZpRZb8+GnkKxXfm6 WSdxb+15JJhXokqfp+ClgnlTzsgdO6E3kWUO0dHg= Received: from DLEE103.ent.ti.com (dlee103.ent.ti.com [157.170.170.33]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 14HE5K14068998 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 17 May 2021 09:05:20 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 17 May 2021 09:05:19 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2 via Frontend Transport; Mon, 17 May 2021 09:05:19 -0500 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 14HE5KUQ027523; Mon, 17 May 2021 09:05:20 -0500 Date: Mon, 17 May 2021 09:05:19 -0500 From: Nishanth Menon To: Kishon Vijay Abraham I CC: Tero Kristo , Rob Herring , , , , Lokesh Vutla Subject: Re: [PATCH 1/4] arm64: dts: ti: k3-j721e-main: Fix external refclk input to SERDES Message-ID: <20210517140519.4ltzvw3k74z72urz@dingo> References: <20210512151209.27560-1-kishon@ti.com> <20210512151209.27560-2-kishon@ti.com> <20210512185157.q5sr2xqf3w5igfte@imagines> <68c95cf1-84fa-2194-7bb1-e3c60e7f1fc0@ti.com> <20210513140137.5uvftgtsku3xfobz@engraving> <81b7dc76-0918-0a95-5715-cf701e638bbe@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <81b7dc76-0918-0a95-5715-cf701e638bbe@ti.com> User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14:00-20210517, Kishon Vijay Abraham I wrote: > Hi Nishanth, > > On 13/05/21 7:31 pm, Nishanth Menon wrote: > > On 17:41-20210513, Kishon Vijay Abraham I wrote: > >> Hi Nishanth, > >> > >> On 13/05/21 12:21 am, Nishanth Menon wrote: > >>> On 20:42-20210512, Kishon Vijay Abraham I wrote: > >>>> Rename the external refclk inputs to the SERDES from > >>>> dummy_cmn_refclk/dummy_cmn_refclk1 to cmn_refclk/cmn_refclk1 > >>>> respectively. Also move the external refclk DT nodes outside the > >>>> cbass_main DT node. Since in j721e common processor board, only the > >>>> cmn_refclk1 is connected to 100MHz clock, fix the clock frequency. > >>>> > >>>> Fixes: afd094ebe69f ("arm64: dts: ti: k3-j721e-main: Add WIZ and SERDES PHY nodes") > >>> > >>> Assume we want this part of 5.13 fixes? > >> > >> This doesn't fix any functionality. Okay for me to go in 5.14 along with > >> the rest of the series. > > > > > >>> > >>>> Signed-off-by: Kishon Vijay Abraham I > >>>> --- > >>>> .../dts/ti/k3-j721e-common-proc-board.dts | 4 ++ > >>>> arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 58 ++++++++++--------- > >>>> 2 files changed, 34 insertions(+), 28 deletions(-) > >>>> > >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>> index 60764366e22b..86f7ab511ee8 100644 > >>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts > >>>> @@ -635,6 +635,10 @@ > >>>> status = "disabled"; > >>>> }; > >>>> > >>>> +&cmn_refclk1 { > >>>> + clock-frequency = <100000000>; > >>>> +}; > >>>> + > >>>> &serdes0 { > >>>> serdes0_pcie_link: link@0 { > >>>> reg = <0>; > >>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>> index c2aa45a3ac79..002a0c1520ee 100644 > >>>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi > >>>> @@ -8,6 +8,20 @@ > >>>> #include > >>>> #include > >>>> > >>>> +/ { > >>>> + cmn_refclk: cmn-refclk { > >>>> + #clock-cells = <0>; > >>>> + compatible = "fixed-clock"; > >>>> + clock-frequency = <0>; > >>>> + }; > >>>> + > >>>> + cmn_refclk1: cmn-refclk1 { > >>> > >>> Just curious: why cant we use the standard nodenames with clock? > >> > >> We can use standard names here. Is there any defined nodename for > >> clocks? clk or clock? Don't see $nodename defined for clocks in > >> dt-schema repository. > > > > Looking at the fixed-clock example, lets go with clock > > Since I have two clocks here adding clock@0 and clock@1 introduces the > following error. > /home/a0393678/repos/linux-wip/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dt.yaml: > /: clock@0: 'anyOf' conditional failed, one must be fixed: > 'reg' is a required property > 'ranges' is a required property > > The current "fixed-clock" binding doesn't allow adding "reg" property. > We'll stick to non standard names? or do you think the binding has to be > fixed? Look at other fixed-clock examples in other arm64 examples https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts/freescale/imx8mm.dtsi#n147 is a good one.. Binding is fine, IMHO. -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D