From: Rob Herring <robh@kernel.org>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Marek Vasut <marex@denx.de>,
dri-devel@lists.freedesktop.org, ch@denx.de,
Sam Ravnborg <sam@ravnborg.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing
Date: Tue, 18 May 2021 07:59:30 -0500 [thread overview]
Message-ID: <20210518125930.GA485447@robh.at.kernel.org> (raw)
In-Reply-To: <YKBBlWXXK8LUc8ac@pendragon.ideasonboard.com>
On Sun, May 16, 2021 at 12:48:05AM +0300, Laurent Pinchart wrote:
> Hi Marek,
>
> Thank you for the patch.
>
> On Sat, May 15, 2021 at 10:39:32PM +0200, Marek Vasut wrote:
> > Add missing spaces to make the diagrams readable, no functional change.
>
> Looks better indeed. The patch view looks bad though, because of the
> tabs. Maybe you could replace them with spaces, while at it ?
It's best to not have tabs in yaml. And if we ever generate any
documentation out of the schema, the tabs would probably cause issues.
Rob
prev parent reply other threads:[~2021-05-18 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-15 20:39 [PATCH] dt-bindings: display: bridge: lvds-codec: Fix spacing Marek Vasut
2021-05-15 21:48 ` Laurent Pinchart
2021-05-15 23:49 ` Marek Vasut
2021-05-16 0:46 ` Laurent Pinchart
2021-05-18 12:59 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518125930.GA485447@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=ch@denx.de \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=marex@denx.de \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).