From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDD3C433ED for ; Wed, 19 May 2021 11:00:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B73C760725 for ; Wed, 19 May 2021 11:00:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237964AbhESLB4 (ORCPT ); Wed, 19 May 2021 07:01:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229720AbhESLBz (ORCPT ); Wed, 19 May 2021 07:01:55 -0400 Received: from the.earth.li (the.earth.li [IPv6:2a00:1098:86:4d:c0ff:ee:15:900d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 70603C06175F; Wed, 19 May 2021 04:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=earth.li; s=the; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject :Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cEL+S5BBsjl3bRxdIpO4xrtFYv5ZClHANR3l6kfeTgg=; b=iEkidWTvaJCpDJldks0VJKqeOD KHAC5YqNa4sb7PoHDpA4Kn6k3hHyYihvnjiUbwOCjd1F6+EZCOwSnQrvx3ZEh+90d7XfSn0WJxt+d TrpMjmcwezfw4BPP4J/mrlCVKAX/WgcfYxHVpt7xkkyF/z4FZBkrplZPpAU93izFqYjLjXTMerxUO Sy9b5XP+gf6z+EXbnqOqVk0v95uPoR6+1s8ep/tq5s3x2/EOm+3v2A5C2t0Uc0MTkNhqTky8NC4N2 dxtXS4dYvySmZEJxTRPQ6pYNXs0s4LZLWLVATi4guypstVG1JflKSVNp4MezVB6+iREvvvU6Yze39 x0BMTP/w==; Received: from noodles by the.earth.li with local (Exim 4.92) (envelope-from ) id 1ljJwG-0002Co-FG; Wed, 19 May 2021 12:00:32 +0100 Date: Wed, 19 May 2021 12:00:32 +0100 From: Jonathan McDowell To: Vinod Koul Cc: Andy Gross , Bjorn Andersson , Rob Herring , Ansuel Smith , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] ARM: dts: qcom: Add tsens details to ipq806x Message-ID: <20210519110032.GQ11733@earth.li> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, May 17, 2021 at 03:12:02PM +0530, Vinod Koul wrote: > On 15-05-21, 17:52, Jonathan McDowell wrote: > > > gcc: clock-controller@900000 { > > - compatible = "qcom,gcc-ipq8064"; > > + compatible = "qcom,gcc-ipq8064", "syscon"; > > Does this belong here No, not sure how that slipped in, will remove for v2. > > reg = <0x00900000 0x4000>; > > #clock-cells = <1>; > > #reset-cells = <1>; > > + #power-domain-cells = <1>; > > + > > + tsens: thermal-sensor@900000 { > > + compatible = "qcom,ipq8064-tsens"; > > + > > + nvmem-cells = <&tsens_calib>, <&tsens_calib_backup>; > > + nvmem-cell-names = "calib", "calib_backup"; > > + interrupts = ; > > + interrupt-names = "uplow"; > > + > > + #qcom,sensors = <11>; > > + #thermal-sensor-cells = <1>; > > + }; > > We have sensor under gcc node..? Weirdly, yes, that seems to be where it lives for the 8064. J. -- I'm dangerous when I know what I'm doing.