From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3436CC433ED for ; Fri, 21 May 2021 02:00:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A8616135C for ; Fri, 21 May 2021 02:00:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238106AbhEUCCE (ORCPT ); Thu, 20 May 2021 22:02:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238093AbhEUCCB (ORCPT ); Thu, 20 May 2021 22:02:01 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D42C4C061763; Thu, 20 May 2021 19:00:39 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id n8so4915191plf.7; Thu, 20 May 2021 19:00:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=9fB9txKIQZNMl67yv7ERq72Q+6wcnvrLhnIU26tnTf4=; b=An1xKWU/mWO08cY0cP24LyKkNnOv5zCCLUdnglRtraCTvQQzxVh9tTfYP1YanUjoR8 gFtYTxBnypDtTZJxyxQ1tMDJtzdMMTs5rHApnAEd/aQWzVn+hLHmzuypSaML2xrdpRCW +atdTnZ2DCoPjdD9qdm1EhlEDGaoVnmocolZmRF7sErnz5ofewaQGpXASxT8QxwUiUai nj86+/F36GPfLpYIIDyoKPdhyetIbbr07I+lFT1YwrnBmgBe0t2Svn7GZ5BNKqRlLY2/ CGzlvZ+aIKnYSNNGv4xYAR9uUG2Ao2Igzhd1uppZXRCZB6hTlZNwDp4EPHaQ6nKsT/a/ loIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=9fB9txKIQZNMl67yv7ERq72Q+6wcnvrLhnIU26tnTf4=; b=rGDRJXOnkNPwOFcApTQTF4Rik5rpOF5f5VX5RGPBomGki5XoA9LO/x8nFPHMPFAell lH+OYtMX6j7EqntVxFRCYfsgjmpqXAtVSHMfCAsTBVyjGESzMe8e0KcGLnnpHvVjwF7+ 6xGKOO4LblKmkjb2gaOX9JIOu+Z0DWeygM4AuWBP27kAApEKJhTyrLnzWtB1meIDCMfR u6BGW3q6q21E1yYvQ1h8JsrszPWtpsos8h3kIjOt+IhIQVRFqYXaoU9w327qPmPGZxDa W7xFQeAV9rZGptnmpXmU/8UqXet0WEqwxrYZ86T/A4akD530eC9n9K3kt0Nd5WlbFPuZ Mw3w== X-Gm-Message-State: AOAM53199GkBLg4N9iRGWnv27o9l/XKa3/iT6PG36TxTc7d/Y9MVbY7b KneKbwIDzCDBrD/3FcM+JJY= X-Google-Smtp-Source: ABdhPJwBofzBAXoo5pDmXX4ye8/TsvSpB7pKcMIb3pVYhLkIdagqbQ5wvHtXHUJZRNsbTl2FgNx8tA== X-Received: by 2002:a17:90a:f811:: with SMTP id ij17mr8130069pjb.63.1621562439317; Thu, 20 May 2021 19:00:39 -0700 (PDT) Received: from taoren-ubuntu-R90MNF91 (c-73-252-146-110.hsd1.ca.comcast.net. [73.252.146.110]) by smtp.gmail.com with ESMTPSA id w74sm2869555pfd.209.2021.05.20.19.00.37 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 May 2021 19:00:39 -0700 (PDT) Date: Thu, 20 May 2021 19:00:34 -0700 From: Tao Ren To: Jamin Lin Cc: Joel Stanley , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:ARM/ASPEED MACHINE SUPPORT" , "moderated list:ARM/ASPEED I2C DRIVER" , Brendan Higgins , open list , Rob Herring , Rayn Chen , "open list:I2C SUBSYSTEM HOST DRIVERS" , Steven Lee , "moderated list:ARM/ASPEED MACHINE SUPPORT" Subject: Re: [PATCH 1/3] i2c: aspeed: avoid new registers definition of AST2600 Message-ID: <20210521020033.GB19153@taoren-ubuntu-R90MNF91> References: <20210519080436.18975-1-jamin_lin@aspeedtech.com> <20210519080436.18975-2-jamin_lin@aspeedtech.com> <20210520033140.GA3656@aspeedtech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210520033140.GA3656@aspeedtech.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Jamin, On Thu, May 20, 2021 at 11:31:41AM +0800, Jamin Lin wrote: > The 05/19/2021 22:59, Joel Stanley wrote: > > On Wed, 19 May 2021 at 08:05, Jamin Lin wrote: > > > > > > The register definition between AST2600 A2 and A3 is different. > > > This patch avoid new registers definition of AST2600 to use > > > this driver. We will submit the path for the new registers > > > definition of AST2600. > > > > The AST2600 v9 datasheet says that bit 2 selects between old and new > > register sets, and that the old register set is the default. > > > > Has the default changed for the A3?, and the datasheet is incorrect? > > > > Does the A3 still support the old register set? > > > We suggest user to use the new i2c driver for AST2600 and we will sumbit > it. This driver is used to AST2500 and AST2400 SOCs. Change this > driver to check global register of i2c to avoid user build the wrong driver. If I understand correctly, the answer implies old register set is still supported in A3 although aspeed suggest people using the new driver/mode? Can you please share more context behind the suggestion? Such as new register mode has better performance? Or some known issues that were deteted in old mode are fixed in new register mode? Cheers, Tao