devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Lucas Stankus <lucas.p.stankus@gmail.com>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
	"Hennerich, Michael" <Michael.Hennerich@analog.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-iio <linux-iio@vger.kernel.org>,
	linux-staging@lists.linux.dev,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	devicetree@vger.kernel.org
Subject: Re: [PATCH v3 0/2] staging: iio: cdc: ad7746: add dt properties for capacitive channel setup
Date: Fri, 21 May 2021 18:30:29 +0100	[thread overview]
Message-ID: <20210521183029.7a13ef25@jic23-huawei> (raw)
In-Reply-To: <CACKVXZCxKpBwzmy4L+TEmbO5nYUVMEjZd7SZ3+1KTOaz3hp89A@mail.gmail.com>

On Wed, 19 May 2021 17:59:31 -0300
Lucas Stankus <lucas.p.stankus@gmail.com> wrote:

> On Sun, May 2, 2021 at 2:49 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Sat, 1 May 2021 09:32:03 -0300
> > Lucas Stankus <lucas.p.stankus@gmail.com> wrote:
> >  
> > > This patch series aims to replace the platform_struct for the ad7746 driver
> > > in favor of device tree bindings, creating the dt-binding documentation in
> > > the process.
> > >
> > > Since the header file was only used to define the struct and the excitation
> > > level values, it was possible to remove the file entirely.
> > >
> > > Changelog v2 -> v3:
> > > - Add application reference note for the inverted EXCX dt bindings
> > > - Replace macro with lookup table for setting the capacitive channel
> > >   excitation voltage
> > >
> > > Lucas Stankus (2):
> > >   dt-bindings: staging: iio: cdc: ad7746: add binding documentation for
> > >     AD7746
> > >   staging: iio: cdc: ad7746: use dt for capacitive channel setup.  
> >
> > Looks good to me.  Thanks!
> >
> > Will leave time for Rob or anyone else to take a look etc before applying.
> >
> > If I seem to have lost it then feel free to give me a poke in a few weeks
> > (it's happened a few times in the past :(
> >
> > Thanks,
> >
> > Jonathan  
> > >
> > >  .../bindings/iio/cdc/adi,ad7746.yaml          | 77 +++++++++++++++++++
> > >  drivers/staging/iio/cdc/ad7746.c              | 54 ++++++++-----
> > >  drivers/staging/iio/cdc/ad7746.h              | 28 -------
> > >  3 files changed, 110 insertions(+), 49 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/iio/cdc/adi,ad7746.yaml
> > >  delete mode 100644 drivers/staging/iio/cdc/ad7746.h
> > >  
> >  
> 
> Hey Jonathan,
> 
> It has been a week or so without any more feedback, so I'm just a pinging here
> to know if this can be applied.

oops. Indeed time I picked these up.  Somehow I had them in the wrong colour
in my horrendous colour based tracking system :(

Now applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to do their worst.

Thanks,

Jonathan

> 
> Thanks,
> Lucas


      reply	other threads:[~2021-05-21 17:29 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-01 12:32 [PATCH v3 0/2] staging: iio: cdc: ad7746: add dt properties for capacitive channel setup Lucas Stankus
2021-05-01 12:32 ` [PATCH v3 1/2] dt-bindings: staging: iio: cdc: ad7746: add binding documentation for AD7746 Lucas Stankus
2021-05-06 14:25   ` Rob Herring
2021-05-01 12:32 ` [PATCH v3 2/2] staging: iio: cdc: ad7746: use dt for capacitive channel setup Lucas Stankus
2021-05-03 10:07   ` Dan Carpenter
2021-05-03 14:44     ` Dan Carpenter
2021-05-02 17:50 ` [PATCH v3 0/2] staging: iio: cdc: ad7746: add dt properties " Jonathan Cameron
2021-05-19 20:59   ` Lucas Stankus
2021-05-21 17:30     ` Jonathan Cameron [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210521183029.7a13ef25@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=lucas.p.stankus@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).