From: Steven Lee <steven_lee@aspeedtech.com>
To: Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
"Andrew Jeffery" <andrew@aj.id.au>,
Adrian Hunter <adrian.hunter@intel.com>,
"Ulf Hansson" <ulf.hansson@linaro.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/ASPEED MACHINE SUPPORT"
<linux-aspeed@lists.ozlabs.org>,
open list <linux-kernel@vger.kernel.org>,
<linux-mmc@vger.kernel.org>,
"moderated list:ASPEED SD/MMC DRIVER" <openbmc@lists.ozlabs.org>
Cc: <steven_lee@aspeedtech.com>, <Hongweiz@ami.com>,
<ryan_chen@aspeedtech.com>, <chin-ting_kuo@aspeedtech.com>
Subject: [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal
Date: Mon, 24 May 2021 15:32:52 +0800 [thread overview]
Message-ID: <20210524073308.9328-1-steven_lee@aspeedtech.com> (raw)
AST2600-A2 EVB has the reference design for enabling SD bus
power and toggling SD bus signal voltage between 3.3v and 1.8v by
GPIO regulators.
This patch series adds sdhci node and gpio regulators in a new dts file
for AST2600-A2 EVB.
The description of the reference design of AST2600-A2 EVB is added
in the new dts file.
This patch also include a helper for updating AST2600 sdhci capability
registers.
Changes from v4:
* Move sdhci node and gpio regulator from aspeed-ast2600-evb-a2.dts
to aspeed-ast2600-evb.dts. Now aspeed-ast2600-evb.dts only supports
A2(or newer) evbs.
* Remove aspeed-ast2600-evb-a2.dts since sdhci nodes were moved to
aspeed-ast2600-evb.dts.
* Add aspeed-ast2600-evb-a1.dts for A1 and A0 evbs.
Changes from v3:
* Remove the example of gpio regulator from dt-bindings.
* Add sdhci node and gpio regulators to a new dts file.
* Move the comment of the reference design to the new
dts file.
* Modify commit message of sdhci-of-aspeed.c.
* Fix coding style issues of sdhci-of-aspeed.c.
* Remove the implementation of eMMC resetc since it has no relevance to
the goal that this patch series want to achieve and it may needs further
discussion about the design of reset behavior.
Changes from v2:
* Move the comment of the reference design from dt-bindings to device tree.
* Add clk-phase binding for eMMC controller.
* Reimplement aspeed_sdc_set_slot_capability().
* Separate the implementation of eMMC reset to another patch file.
* Fix yaml document error per the report of dt_binding_check and
dtbs_check.
Changes from v1:
* Add the device tree example for AST2600 A2 EVB in dt-bindings
document
* Add timing-phase for eMMC controller.
* Remove power-gpio and power-switch-gpio from sdhci driver, they should
be handled by regulator.
* Add a helper to update capability registers in the driver.
* Sync sdhci settings from device tree to SoC capability registers.
* Sync timing-phase from device tree to SoC Clock Phase Control
register
Please help to review.
Regards,
Steven
Steven Lee (4):
ARM: dts: aspeed: ast2600evb: Add sdhci node and gpio regulator for A2
evb.
ARM: dts: aspeed: ast2600evb: Add phase correction for emmc
controller.
ARM: dts: aspeed: ast2600evb: Add dts file for A1 and A0.
mmc: sdhci-of-aspeed: Configure the SDHCIs as specified by the
devicetree.
arch/arm/boot/dts/aspeed-ast2600-evb-a1.dts | 15 ++++
arch/arm/boot/dts/aspeed-ast2600-evb.dts | 87 ++++++++++++++++++++-
drivers/mmc/host/sdhci-of-aspeed.c | 48 ++++++++++++
3 files changed, 149 insertions(+), 1 deletion(-)
create mode 100644 arch/arm/boot/dts/aspeed-ast2600-evb-a1.dts
--
2.17.1
next reply other threads:[~2021-05-24 7:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 7:32 Steven Lee [this message]
2021-05-24 7:32 ` [PATCH v5 1/4] ARM: dts: aspeed: ast2600evb: Add sdhci node and gpio regulator for A2 evb Steven Lee
2021-05-25 1:00 ` Andrew Jeffery
2021-05-24 7:32 ` [PATCH v5 2/4] ARM: dts: aspeed: ast2600evb: Add phase correction for emmc controller Steven Lee
2021-05-24 7:32 ` [PATCH v5 3/4] ARM: dts: aspeed: ast2600evb: Add dts file for A1 and A0 Steven Lee
2021-05-25 1:00 ` Andrew Jeffery
2021-05-24 7:32 ` [PATCH v5 4/4] mmc: sdhci-of-aspeed: Configure the SDHCIs as specified by the devicetree Steven Lee
2021-05-24 14:11 ` Ulf Hansson
2021-05-25 7:55 ` [PATCH v5 0/4] mmc: sdhci-of-aspeed: Support toggling SD bus signal Joel Stanley
2021-05-25 9:48 ` Steven Lee
2021-05-25 12:56 ` Joel Stanley
2021-05-25 22:59 ` Andrew Jeffery
2021-06-07 0:59 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210524073308.9328-1-steven_lee@aspeedtech.com \
--to=steven_lee@aspeedtech.com \
--cc=Hongweiz@ami.com \
--cc=adrian.hunter@intel.com \
--cc=andrew@aj.id.au \
--cc=chin-ting_kuo@aspeedtech.com \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=robh+dt@kernel.org \
--cc=ryan_chen@aspeedtech.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).