From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 562DFC04FF3 for ; Mon, 24 May 2021 13:39:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37022613B0 for ; Mon, 24 May 2021 13:39:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232922AbhEXNkj (ORCPT ); Mon, 24 May 2021 09:40:39 -0400 Received: from wnew3-smtp.messagingengine.com ([64.147.123.17]:58813 "EHLO wnew3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232456AbhEXNki (ORCPT ); Mon, 24 May 2021 09:40:38 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id 1B53C2685; Mon, 24 May 2021 09:39:09 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Mon, 24 May 2021 09:39:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm2; bh=s/NM62L3Og2Ajx92SsKLLhMAsWU lDMHJJUgar/CuuyY=; b=AH+1x3mWyzoPAuqEmOjSdf9NVKXPq4ESFoEih3CtgKq 91w//vo4s3/NB3tRwvoHyucf0T8J2F4ErGm+SwbRoFYbz2FHqSMtQzbGPxTRe1yH MtFD+8PIQ2RHqJVWuPrgLRRg67jDjd/Tvzl9lh4NSHVKovUp0e/A5nQYpVay7LwI 7h0tFdBTjCz5rVaKbWZNRNu+ZlymcWuQ8RI+/ZUFWyFmYdw8J9j+0d+Y4gpxGPVW IX1N4X+bukknM8DrGdwUGR+FtWV2b1zEj4EqcSNhx6HMnyl9eSxvUGNI2U8MZ+/4 9jTeg9m1+c0uDbIykYpdd1IKzGzPI3kXkcKGneDp2ZA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=s/NM62 L3Og2Ajx92SsKLLhMAsWUlDMHJJUgar/CuuyY=; b=diD59LTdjW4BEsvkAdgJl9 ZMNasLZ6FLNm+bbeKBMBXEOAXzUHJqrucsikh/TNwhuX9aIv0uZ5tOrCwD/Nezqk /lAcrkNiNfou1WTPaL+c/IEwX4XwGCIRAw9gVrFav2rewtZWxTpJ24N7VPTSAOLr 7a05iIoVEg9xCd98WRtRB1hhIdu2eDyc2N+EgVQVZ3cHdTALJGPsh+qLzsMl8RaZ rxZWyhIGT6Vi1uGfwEgGi5fSMYVI6R7F+PNIf0FTrfXK56vivT2pRc4DoEXLI79g 79CLE3JPda8iXOqKdpvm9BOml1LrDguVoKoUtYMM3c5AmJpqKnOa7ZsmaCIxfOUg == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejledgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepveevfeffudeviedtgeethffhteeuffetfeffvdehvedvheetteehvdelfffg jedvnecuffhomhgrihhnpehkvghrnhgvlhdrohhrghenucfkphepledtrdekledrieekrd ejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehm rgigihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: from localhost (lfbn-tou-1-1502-76.w90-89.abo.wanadoo.fr [90.89.68.76]) by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 24 May 2021 09:39:05 -0400 (EDT) Date: Mon, 24 May 2021 15:39:04 +0200 From: Maxime Ripard To: Mark Brown , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , dri-devel@lists.freedesktop.org, Daniel Vetter , David Airlie , Maarten Lankhorst , Thomas Zimmermann Cc: Nicolas Saenz Julienne , Rob Herring , devicetree@vger.kernel.org, alsa-devel@alsa-project.org, bcm-kernel-feedback-list@broadcom.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Dave Stevenson , Phil Elwell , Tim Gover , Dom Cobley , Daniel Vetter , linux-rpi-kernel@lists.infradead.org, Eric Anholt Subject: Re: [PATCH 00/11] drm/vc4: hdmi: Enable Channel Mapping, IEC958, HBR Passthrough using hdmi-codec Message-ID: <20210524133904.kgkh6xd3m5c2j3xa@gilmour> References: <20210507140334.204865-1-maxime@cerno.tech> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tmkkjaxkjbof4vya" Content-Disposition: inline In-Reply-To: <20210507140334.204865-1-maxime@cerno.tech> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org --tmkkjaxkjbof4vya Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Fri, May 07, 2021 at 04:03:23PM +0200, Maxime Ripard wrote: > Hi, >=20 > hdmi-codec allows to have a lot of HDMI-audio related infrastructure in p= lace, > it's missing a few controls to be able to provide HBR passthrough. This s= eries > adds more infrastructure for the drivers, and leverages it in the vc4 HDMI > controller driver. >=20 > One thing that felt a bit weird is that even though > https://www.kernel.org/doc/html/latest/sound/kernel-api/writing-an-alsa-d= river.html#iec958-s-pdif > mentions that the iec958 mask control should be a mixer control and the > default control should be a PCM one, it feels a bit weird to have two dif= ferent > control type for two controls so similar, and other drivers are pretty > inconsistent with this. Should we update the documentation? Any comments on this series? Thanks! Maxime --tmkkjaxkjbof4vya Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYKusdwAKCRDj7w1vZxhR xVj3AP4uZTPoREfuFK3oXQIWtdDspcef5aq6+8o5wrl7gjJzFwD9GbDNuVOSZ62m P4t+tqoRf1AhEyG+nYTwbpCM/Pkkqwc= =nosZ -----END PGP SIGNATURE----- --tmkkjaxkjbof4vya--