From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC610C47082 for ; Wed, 26 May 2021 10:07:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8CDED6124C for ; Wed, 26 May 2021 10:07:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233812AbhEZKJ2 (ORCPT ); Wed, 26 May 2021 06:09:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58102 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233731AbhEZKJ2 (ORCPT ); Wed, 26 May 2021 06:09:28 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7D88DC061574 for ; Wed, 26 May 2021 03:07:57 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id kr9so511356pjb.5 for ; Wed, 26 May 2021 03:07:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=iPLF4+a0+7osNgqIih0t63HrK/7cIyUQjVdMCaByTx4=; b=McT6WvIIhYAITiYiVmvf9diDdxUIeXVUj80svSmWGZkKzERBTUuSJICT+1aesu0rp6 lr80GxhsP2CYf5+Lw6jVHyvsQFNY8zWtYKk8qr+J2a08R8+xAAAhuyNthUrYDEUHSLar bZK+isSOTBLoqPBpXTUSRBlE4gZRemVynfwxuq7PqcQ6EqzMDe+0asg3YL5NbA3tHVAw AK/trgfEAqzrGO5b68L32EIpaomzB2jSVCI1OFzs5WBBx/zAOb+DdAk9itkr711JC7eP 4EVN6K6LceUbBdPd7hJMMCIuVTRgEF5sUXjwoS113it4WpU2qgqCokQ4cO60j/aT0bce lzug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=iPLF4+a0+7osNgqIih0t63HrK/7cIyUQjVdMCaByTx4=; b=IZv3w191A1CBONYLMHnHo2Hw4CwcOi0dVSU3sJxecikyqeHyPxnVFTgzuYpZT/AKsk pA3TVT+wtz/y+jgFvetXhT/oSGNFX/+IKZUTaKT14S6vSyP3A/7X1SNg3yz9liK6Pbao Uc2piVz0Dj6xY3v+gqqTTH5AZo6RSvYV7n8xzMWHlGu3Ra3lAksoDspXFCzHAw7QNMjz gDJ0K1uNmb/Qr04qZhe4I2d2Icpm8/rHal3YAl40Ove1sXo+XJIXHjKfsDfmzDCql0Jw yWnH7+dxec7kb8KnW4qd5kLOQv5h0BlYSbVZXP34eG6qg0v72AGnXAnzJqE2oyhA3AGb uwGQ== X-Gm-Message-State: AOAM530T3FDbl/eJNd7XZcZsyU1Wr7fJpT/AoEIep9oEDLPFGj5GL5ld JDAsMl3OwvP7V2eTjNztzOa4 X-Google-Smtp-Source: ABdhPJxzbNRZCM/TUHJmvxFI6Zega3duBzCjyNdGs7pP8S8t49WpLEQQCp9uUr72qRdzGtzi1G/axA== X-Received: by 2002:a17:90a:8902:: with SMTP id u2mr35505244pjn.143.1622023676967; Wed, 26 May 2021 03:07:56 -0700 (PDT) Received: from work ([120.138.12.4]) by smtp.gmail.com with ESMTPSA id 184sm14858556pfv.38.2021.05.26.03.07.53 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 May 2021 03:07:55 -0700 (PDT) Date: Wed, 26 May 2021 15:37:43 +0530 From: Manivannan Sadhasivam To: Cristian Ciocaltea Cc: Stephen Boyd , Rob Herring , Andreas =?iso-8859-1?Q?F=E4rber?= , Michael Turquette , Edgar Bernardi Righi , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-actions@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/6] clk: actions: Fix SD clocks factor table on Owl S500 SoC Message-ID: <20210526100719.GC10723@work> References: <973b08fe414321ba4ade096a4917cadc2013426e.1615221459.git.cristian.ciocaltea@gmail.com> <20210316035845.GB1798@thinkpad> <20210316181437.GB1111731@BV030612LT> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210316181437.GB1111731@BV030612LT> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Mar 16, 2021 at 08:14:37PM +0200, Cristian Ciocaltea wrote: > Hi Mani, > > Thanks for reviewing this patch series! > > On Tue, Mar 16, 2021 at 09:28:45AM +0530, Manivannan Sadhasivam wrote: > > On Mon, Mar 08, 2021 at 07:18:27PM +0200, Cristian Ciocaltea wrote: > > > Drop the unsupported entries in the factor table used for the SD[0-2] > > > clocks definitions on the Actions Semi Owl S500 SoC. > > > > > > Fixes: ed6b4795ece4 ("clk: actions: Add clock driver for S500 SoC") > > > Signed-off-by: Cristian Ciocaltea > > > --- > > > drivers/clk/actions/owl-s500.c | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/drivers/clk/actions/owl-s500.c b/drivers/clk/actions/owl-s500.c > > > index 75b7186185b0..69cd959205f5 100644 > > > --- a/drivers/clk/actions/owl-s500.c > > > +++ b/drivers/clk/actions/owl-s500.c > > > @@ -127,8 +127,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > { 12, 1, 13 }, { 13, 1, 14 }, { 14, 1, 15 }, { 15, 1, 16 }, > > > { 16, 1, 17 }, { 17, 1, 18 }, { 18, 1, 19 }, { 19, 1, 20 }, > > > { 20, 1, 21 }, { 21, 1, 22 }, { 22, 1, 23 }, { 23, 1, 24 }, > > > - { 24, 1, 25 }, { 25, 1, 26 }, { 26, 1, 27 }, { 27, 1, 28 }, > > > - { 28, 1, 29 }, { 29, 1, 30 }, { 30, 1, 31 }, { 31, 1, 32 }, > > [...] > This is basically what gets translated to sd_factor_table and I removed > the extra entries 25..31. Actually I also dropped the 24th one, since > that would give us an odd number of items, although I'm not quite sure > this is a bug in the xapp-le code or the HW is really supposed to work > like that. > In my datasheet I can see the factor values till 24. So let's remove the entries from 25-31. Thanks, Mani > Kind regards, > Cristi > > > Thanks, > > Mani > > > > > > > > /* bit8: /128 */ > > > { 256, 1, 1 * 128 }, { 257, 1, 2 * 128 }, { 258, 1, 3 * 128 }, { 259, 1, 4 * 128 }, > > > @@ -137,8 +135,6 @@ static struct clk_factor_table sd_factor_table[] = { > > > { 268, 1, 13 * 128 }, { 269, 1, 14 * 128 }, { 270, 1, 15 * 128 }, { 271, 1, 16 * 128 }, > > > { 272, 1, 17 * 128 }, { 273, 1, 18 * 128 }, { 274, 1, 19 * 128 }, { 275, 1, 20 * 128 }, > > > { 276, 1, 21 * 128 }, { 277, 1, 22 * 128 }, { 278, 1, 23 * 128 }, { 279, 1, 24 * 128 }, > > > - { 280, 1, 25 * 128 }, { 281, 1, 26 * 128 }, { 282, 1, 27 * 128 }, { 283, 1, 28 * 128 }, > > > - { 284, 1, 29 * 128 }, { 285, 1, 30 * 128 }, { 286, 1, 31 * 128 }, { 287, 1, 32 * 128 }, > > > { 0, 0, 0 }, > > > }; > > > > > > -- > > > 2.30.1 > > >