From: Nishanth Menon <nm@ti.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
PCI <linux-pci@vger.kernel.org>, <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Lokesh Vutla <lokeshvutla@ti.com>
Subject: Re: [PATCH] dt-bindings: PCI: ti,am65: Convert PCIe host/endpoint mode dt-bindings to YAML
Date: Wed, 26 May 2021 13:59:17 -0500 [thread overview]
Message-ID: <20210526185917.23icpjsuc37x3pae@slashing> (raw)
In-Reply-To: <CAL_Jsq+7AD4WXggRrVVb=HKVmuomda3KVXuC1mcjYwbgnWRUkg@mail.gmail.com>
On 11:04-20210526, Rob Herring wrote:
[...]
> > > +unevaluatedProperties: false
> >
> > Is it possible to lock this down further with additionalProperties: false?
>
> unevaluatedProperties is what we want here.
>
> > I could add some ridiculous property like system-controller; to the
> > example and the checks wont catch it.
>
> Yes, because unevaluatedProperties is currently unimplemented. Once
> the upstream jsonschema tool supports it[1], there will be warnings.
> The other way we could address this is there are $ref resolving tools
> that flatten schemas.
>
> [1] https://github.com/Julian/jsonschema/issues/613#issuecomment-636026577
Aha.. Thanks.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-05-26 18:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 13:47 [PATCH] dt-bindings: PCI: ti,am65: Convert PCIe host/endpoint mode dt-bindings to YAML Kishon Vijay Abraham I
2021-05-26 14:09 ` Nishanth Menon
2021-05-26 16:04 ` Rob Herring
2021-05-26 18:59 ` Nishanth Menon [this message]
2021-05-27 14:23 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210526185917.23icpjsuc37x3pae@slashing \
--to=nm@ti.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).