From: Sudeep Holla <sudeep.holla@arm.com>
To: Rob Herring <robh@kernel.org>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
devicetree@vger.kernel.org, Jerome Brunet <jbrunet@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Sudeep Holla <sudeep.holla@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
linux-arm-kernel@lists.infradead.org,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert to json schema
Date: Thu, 27 May 2021 17:17:12 +0100 [thread overview]
Message-ID: <20210527161702.wzilr4z5tuzqfy5g@bogus> (raw)
In-Reply-To: <1622125407.773675.731787.nullmailer@robh.at.kernel.org>
Hi Rob,
On Thu, May 27, 2021 at 09:23:27AM -0500, Rob Herring wrote:
> On Wed, 26 May 2021 19:28:04 +0100, Sudeep Holla wrote:
> > Convert the old text format binding for System Control and Power Interface
> > (SCPI) Message Protocol into the new and shiny YAML format.
> >
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Cc: Kevin Hilman <khilman@baylibre.com>
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Jerome Brunet <jbrunet@baylibre.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> > .../devicetree/bindings/arm/arm,scpi.txt | 204 -------------
> > .../bindings/firmware/arm,scpi.yaml | 284 ++++++++++++++++++
> > MAINTAINERS | 2 +-
> > 3 files changed, 285 insertions(+), 205 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scpi.txt
> > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: $nodename:0: 'scpi' was expected
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: reg: [[0, 788529152, 0, 512]] is not of type 'object'
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: 'shmem' is a required property
> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
>
> See https://patchwork.ozlabs.org/patch/1484217
>
> This check can fail if there are any dependencies. The base for a patch
> series is generally the most recent rc1.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit.
>
I have fixed this in 6/8. I can merge them but since I wasn't aware of how
this might get merged, I split the patch. Converting to yaml triggered issue
with mhu yaml schema as the example is wrong.
--
Regards,
Sudeep
next prev parent reply other threads:[~2021-05-27 16:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:27 [PATCH 0/8] dt-bindings: firmware: Convert SCPI and SCMI to json schema Sudeep Holla
2021-05-26 18:28 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla
2021-05-27 20:25 ` Rob Herring
2021-05-31 8:15 ` Sudeep Holla
2021-05-31 8:20 ` Sudeep Holla
2021-06-01 13:37 ` Rob Herring
2021-06-01 13:53 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 2/8] dt-bindings: firmware: arm,scmi: Move arm,scmi-shmem " Sudeep Holla
2021-05-26 18:28 ` [PATCH 3/8] dt-bindings: firmware: juno,scpi: Move to sram.yaml " Sudeep Holla
2021-05-26 18:28 ` [PATCH 4/8] dt-bindings: firmware: amlogic,scpi: Move arm,scpi-shmem to " Sudeep Holla
2021-05-26 18:28 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert " Sudeep Holla
2021-05-27 14:23 ` Rob Herring
2021-05-27 16:17 ` Sudeep Holla [this message]
2021-05-26 18:28 ` [PATCH 6/8] dt-bindings: mailbox : arm,mhu: Fix arm,scpi example used here Sudeep Holla
2021-05-27 14:23 ` [PATCH 6/8] dt-bindings: mailbox : arm, mhu: Fix arm, scpi " Rob Herring
2021-05-27 16:25 ` Sudeep Holla
2021-05-27 20:07 ` Rob Herring
2021-05-31 8:17 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: Convert to json schema Sudeep Holla
2021-05-27 20:33 ` Rob Herring
2021-05-31 8:36 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Sudeep Holla
2021-05-26 18:35 ` Sudeep Holla
2021-05-27 20:15 ` Rob Herring
2021-05-27 6:37 ` Etienne Carriere
2021-05-27 10:53 ` Sudeep Holla
2021-05-27 10:33 ` Cristian Marussi
2021-05-27 10:49 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527161702.wzilr4z5tuzqfy5g@bogus \
--to=sudeep.holla@arm.com \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).