From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C8B3C4708A for ; Thu, 27 May 2021 16:17:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CDAAD60FF3 for ; Thu, 27 May 2021 16:17:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236365AbhE0QTI (ORCPT ); Thu, 27 May 2021 12:19:08 -0400 Received: from foss.arm.com ([217.140.110.172]:59964 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232565AbhE0QTD (ORCPT ); Thu, 27 May 2021 12:19:03 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BCE2011D4; Thu, 27 May 2021 09:17:24 -0700 (PDT) Received: from bogus (unknown [10.57.70.210]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D8E4E3F719; Thu, 27 May 2021 09:17:22 -0700 (PDT) Date: Thu, 27 May 2021 17:17:12 +0100 From: Sudeep Holla To: Rob Herring Cc: Cristian Marussi , devicetree@vger.kernel.org, Jerome Brunet , Rob Herring , Sudeep Holla , Kevin Hilman , linux-arm-kernel@lists.infradead.org, Neil Armstrong Subject: Re: [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert to json schema Message-ID: <20210527161702.wzilr4z5tuzqfy5g@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-6-sudeep.holla@arm.com> <1622125407.773675.731787.nullmailer@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1622125407.773675.731787.nullmailer@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Rob, On Thu, May 27, 2021 at 09:23:27AM -0500, Rob Herring wrote: > On Wed, 26 May 2021 19:28:04 +0100, Sudeep Holla wrote: > > Convert the old text format binding for System Control and Power Interface > > (SCPI) Message Protocol into the new and shiny YAML format. > > > > Cc: Rob Herring > > Cc: Kevin Hilman > > Cc: Neil Armstrong > > Cc: Jerome Brunet > > Cc: Viresh Kumar > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/arm,scpi.txt | 204 ------------- > > .../bindings/firmware/arm,scpi.yaml | 284 ++++++++++++++++++ > > MAINTAINERS | 2 +- > > 3 files changed, 285 insertions(+), 205 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/arm,scpi.txt > > create mode 100644 Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: $nodename:0: 'scpi' was expected > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: reg: [[0, 788529152, 0, 512]] is not of type 'object' > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mailbox/arm,mhu.example.dt.yaml: scpi@2f000000: 'shmem' is a required property > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > See https://patchwork.ozlabs.org/patch/1484217 > > This check can fail if there are any dependencies. The base for a patch > series is generally the most recent rc1. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit. > I have fixed this in 6/8. I can merge them but since I wasn't aware of how this might get merged, I split the patch. Converting to yaml triggered issue with mhu yaml schema as the example is wrong. -- Regards, Sudeep