From: Rob Herring <robh@kernel.org>
To: Sudeep Holla <sudeep.holla@arm.com>
Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Cristian Marussi <cristian.marussi@arm.com>,
Kevin Hilman <khilman@baylibre.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>
Subject: Re: [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: Convert to json schema
Date: Thu, 27 May 2021 15:33:27 -0500 [thread overview]
Message-ID: <20210527203327.GA1356362@robh.at.kernel.org> (raw)
In-Reply-To: <20210526182807.548118-8-sudeep.holla@arm.com>
On Wed, May 26, 2021 at 07:28:06PM +0100, Sudeep Holla wrote:
> Convert/merge the existing text format SCPI binding additions for
> amlogic,scpi into the common arm,scpi json scheme.
>
> Couple of things to note:
> "amlogic,meson-gxbb-scpi" is always used with "arm,scpi-pre-1.0"
> hence no need for separate "arm,scpi-pre-1.0" standalone entry and
> "amlogic,meson-gxbb-scpi-sensors" is used always with "arm,scpi-sensors"
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Jerome Brunet <jbrunet@baylibre.com>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
> .../devicetree/bindings/arm/amlogic,scpi.txt | 15 ---------------
> .../devicetree/bindings/firmware/arm,scpi.yaml | 4 ++++
> 2 files changed, 4 insertions(+), 15 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/amlogic,scpi.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> deleted file mode 100644
> index ebfe302fb747..000000000000
> --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt
> +++ /dev/null
> @@ -1,15 +0,0 @@
> -System Control and Power Interface (SCPI) Message Protocol
> -(in addition to the standard binding in [0])
> -----------------------------------------------------------
> -Required properties
> -
> -- compatible : should be "amlogic,meson-gxbb-scpi"
> -
> -Sensor bindings for the sensors based on SCPI Message Protocol
> ---------------------------------------------------------------
> -SCPI provides an API to access the various sensors on the SoC.
> -
> -Required properties:
> -- compatible : should be "amlogic,meson-gxbb-scpi-sensors".
> -
> -[0] Documentation/devicetree/bindings/arm/arm,scpi.txt
> diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> index 9c115e9c1536..d1179a4ea4e9 100644
> --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml
> @@ -34,6 +34,7 @@ description: |
> to SCPI v1.0
> items:
> - const: arm,scpi-pre-1.0
> + - const: amlogic,meson-gxbb-scpi
This says that compatible should be: "arm,scpi-pre-1.0", "amlogic,meson-gxbb-scpi"
The order would be wrong and you lost supporting 'arm,scpi-pre-1.0' by
itself. You want an enum here if it is either one or another items list
if it is 2 entries.
Rob
next prev parent reply other threads:[~2021-05-27 20:33 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 18:27 [PATCH 0/8] dt-bindings: firmware: Convert SCPI and SCMI to json schema Sudeep Holla
2021-05-26 18:28 ` [PATCH 1/8] dt-bindings: firmware: arm,scpi: Move arm,scpi-shmem " Sudeep Holla
2021-05-27 20:25 ` Rob Herring
2021-05-31 8:15 ` Sudeep Holla
2021-05-31 8:20 ` Sudeep Holla
2021-06-01 13:37 ` Rob Herring
2021-06-01 13:53 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 2/8] dt-bindings: firmware: arm,scmi: Move arm,scmi-shmem " Sudeep Holla
2021-05-26 18:28 ` [PATCH 3/8] dt-bindings: firmware: juno,scpi: Move to sram.yaml " Sudeep Holla
2021-05-26 18:28 ` [PATCH 4/8] dt-bindings: firmware: amlogic,scpi: Move arm,scpi-shmem to " Sudeep Holla
2021-05-26 18:28 ` [PATCH 5/8] dt-bindings: firmware: arm,scpi: Convert " Sudeep Holla
2021-05-27 14:23 ` Rob Herring
2021-05-27 16:17 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 6/8] dt-bindings: mailbox : arm,mhu: Fix arm,scpi example used here Sudeep Holla
2021-05-27 14:23 ` [PATCH 6/8] dt-bindings: mailbox : arm, mhu: Fix arm, scpi " Rob Herring
2021-05-27 16:25 ` Sudeep Holla
2021-05-27 20:07 ` Rob Herring
2021-05-31 8:17 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: Convert to json schema Sudeep Holla
2021-05-27 20:33 ` Rob Herring [this message]
2021-05-31 8:36 ` Sudeep Holla
2021-05-26 18:28 ` [PATCH 8/8] dt-bindings: firmware: arm,scmi: " Sudeep Holla
2021-05-26 18:35 ` Sudeep Holla
2021-05-27 20:15 ` Rob Herring
2021-05-27 6:37 ` Etienne Carriere
2021-05-27 10:53 ` Sudeep Holla
2021-05-27 10:33 ` Cristian Marussi
2021-05-27 10:49 ` Sudeep Holla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210527203327.GA1356362@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=cristian.marussi@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).