From: Rudi Heitbaum <rudi@heitbaum.com>
To: Mark Brown <broonie@kernel.org>
Cc: Ezequiel Garcia <ezequiel@collabora.com>,
Peter Geis <pgwipeout@gmail.com>,
devicetree@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
chenjh@rock-chips.com
Subject: Re: [PATCH] regulator: fan53555: add back tcs4526
Date: Fri, 28 May 2021 10:27:41 +0000 [thread overview]
Message-ID: <20210528102737.GA418788@96e513df87d1> (raw)
In-Reply-To: <YK+ZMdD+7uqQwCow@sirena.org.uk>
Hi Mark,
I have submiited the v2 patch. Thanks for the feedback too.
On Thu, May 27, 2021 at 02:05:53PM +0100, Mark Brown wrote:
> On Thu, May 27, 2021 at 08:51:27AM -0300, Ezequiel Garcia wrote:
> > On Thu, 2021-05-27 at 10:59 +0000, Rudi Heitbaum wrote:
> > > + /delete-property/ operating-points-v2;
> > Removal of the operating points kind of makes the gpu regulator moot,
> > don't you think?
> It's still better to say what the supply is even if it can't be
> changed - that stops you getting warnings about substituting in a
> dummy regulator and allows the consumer to read the current state
> of the regulator in case that's useful.
I'll look into this.
Thank you all for the feedback and direction on the dts.
> > > +???????????????regulator-compatible = "fan53555-reg";
>
> > I can be wrong, but I think regulator-compatible is deprecated.
>
> Yes.
will action
> > > +???????????????regulator-boot-on;
>
> > Just out of curiosity, is regulator-boot-on really needed for the GPU?
>
> It should only be used if it's not possible to read the state of
> the regulator enable from the hardware.
will do further testing
next prev parent reply other threads:[~2021-05-28 10:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-26 16:23 [PATCH] regulator: fan53555: add back tcs4526 Rudi Heitbaum
2021-05-26 18:41 ` Peter Geis
2021-05-27 10:59 ` Rudi Heitbaum
2021-05-27 11:26 ` Peter Geis
2021-05-27 13:03 ` Mark Brown
2021-05-27 11:51 ` Ezequiel Garcia
2021-05-27 12:29 ` Rudi Heitbaum
2021-05-27 13:05 ` Mark Brown
2021-05-28 10:27 ` Rudi Heitbaum [this message]
2021-05-28 10:19 ` [PATCH v2] regulator: fan53555: add tcs4526 Rudi Heitbaum
2021-06-01 12:56 ` Mark Brown
2021-06-04 16:32 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210528102737.GA418788@96e513df87d1 \
--to=rudi@heitbaum.com \
--cc=broonie@kernel.org \
--cc=chenjh@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=pgwipeout@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).