From: Liam Beguin <liambeguin@gmail.com>
To: liambeguin@gmail.com, peda@axentia.se, jic23@kernel.org,
lars@metafoo.de, pmeerw@pmeerw.net
Cc: linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org
Subject: [PATCH v1 2/9] iio: inkern: error out on unsupported offset type
Date: Sat, 29 May 2021 20:59:10 -0400 [thread overview]
Message-ID: <20210530005917.20953-3-liambeguin@gmail.com> (raw)
In-Reply-To: <20210530005917.20953-1-liambeguin@gmail.com>
From: Liam Beguin <lvb@xiphos.com>
iio_convert_raw_to_processed_unlocked() assumes the offset is an
integer. Make that clear to the consumer by returning an error when an
unsupported offset type is detected.
Signed-off-by: Liam Beguin <lvb@xiphos.com>
---
drivers/iio/inkern.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/inkern.c b/drivers/iio/inkern.c
index 4b6a8e11116a..dede4536d499 100644
--- a/drivers/iio/inkern.c
+++ b/drivers/iio/inkern.c
@@ -595,8 +595,12 @@ static int iio_convert_raw_to_processed_unlocked(struct iio_channel *chan,
int ret;
ret = iio_channel_read(chan, &offset, NULL, IIO_CHAN_INFO_OFFSET);
- if (ret >= 0)
+ if (ret == IIO_VAL_INT) {
raw64 += offset;
+ } else if (ret >= 0) {
+ dev_err(&chan->indio_dev->dev, "unsupported offset type");
+ return -EINVAL;
+ }
scale_type = iio_channel_read(chan, &scale_val, &scale_val2,
IIO_CHAN_INFO_SCALE);
--
2.30.1.489.g328c10930387
next prev parent reply other threads:[~2021-05-30 0:59 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 0:59 [PATCH v1 0/9] iio: afe: add temperature rescaling support Liam Beguin
2021-05-30 0:59 ` [PATCH v1 1/9] iio: inkern: always apply scale requested by consumer Liam Beguin
2021-05-31 13:39 ` Peter Rosin
2021-05-30 0:59 ` Liam Beguin [this message]
2021-05-31 9:45 ` [PATCH v1 2/9] iio: inkern: error out on unsupported offset type Peter Rosin
2021-05-31 13:31 ` Liam Beguin
2021-05-30 0:59 ` [PATCH v1 3/9] iio: afe: rescale: use core to get processed value Liam Beguin
2021-05-31 7:09 ` Peter Rosin
2021-05-31 13:23 ` Liam Beguin
2021-06-01 16:22 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 4/9] iio: afe: rescale: add offset support Liam Beguin
2021-05-31 8:52 ` Peter Rosin
2021-05-31 13:36 ` Liam Beguin
2021-05-31 14:08 ` Peter Rosin
2021-05-31 14:51 ` Liam Beguin
2021-05-31 16:25 ` Peter Rosin
2021-05-31 17:42 ` Liam Beguin
2021-06-01 16:31 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 5/9] iio: afe: rescale: add support for temperature sensors Liam Beguin
2021-06-01 16:34 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 6/9] dt-bindings: iio: afe: update MAINTAINERS file Liam Beguin
2021-05-31 7:57 ` Peter Rosin
2021-05-30 0:59 ` [PATCH v1 7/9] dt-bindings: iio: afe: add binding for temperature-sense-rtd Liam Beguin
2021-06-01 16:43 ` Jonathan Cameron
2021-06-04 21:17 ` Rob Herring
2021-06-05 14:58 ` Jonathan Cameron
2021-05-30 0:59 ` [PATCH v1 8/9] dt-bindings: iio: afe: add binding for temperature-sense-current Liam Beguin
2021-05-31 7:28 ` Peter Rosin
2021-05-31 8:58 ` Peter Rosin
2021-05-31 13:41 ` Liam Beguin
2021-06-01 16:47 ` Jonathan Cameron
2021-06-04 21:21 ` Rob Herring
2021-05-30 0:59 ` [PATCH v1 9/9] dt-bindings: iio: afe: add binding for temperature-sense-amplifier Liam Beguin
2021-05-31 7:32 ` Peter Rosin
2021-05-31 14:03 ` Liam Beguin
2021-06-01 16:02 ` Jonathan Cameron
2021-06-01 16:07 ` Jonathan Cameron
2021-06-01 15:59 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210530005917.20953-3-liambeguin@gmail.com \
--to=liambeguin@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peda@axentia.se \
--cc=pmeerw@pmeerw.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).