From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43500C4708F for ; Mon, 31 May 2021 08:36:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C5D760E08 for ; Mon, 31 May 2021 08:36:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230299AbhEaIie (ORCPT ); Mon, 31 May 2021 04:38:34 -0400 Received: from foss.arm.com ([217.140.110.172]:51258 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230315AbhEaIie (ORCPT ); Mon, 31 May 2021 04:38:34 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 96AE56D; Mon, 31 May 2021 01:36:54 -0700 (PDT) Received: from bogus (unknown [10.57.72.241]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 228D03F73D; Mon, 31 May 2021 01:36:52 -0700 (PDT) Date: Mon, 31 May 2021 09:36:47 +0100 From: Sudeep Holla To: Rob Herring Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Cristian Marussi , Kevin Hilman , Neil Armstrong , Jerome Brunet Subject: Re: [PATCH 7/8] dt-bindings: firmware: amlogic,scpi: Convert to json schema Message-ID: <20210531083647.w4caop4v6vjpo2i2@bogus> References: <20210526182807.548118-1-sudeep.holla@arm.com> <20210526182807.548118-8-sudeep.holla@arm.com> <20210527203327.GA1356362@robh.at.kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210527203327.GA1356362@robh.at.kernel.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, May 27, 2021 at 03:33:27PM -0500, Rob Herring wrote: > On Wed, May 26, 2021 at 07:28:06PM +0100, Sudeep Holla wrote: > > Convert/merge the existing text format SCPI binding additions for > > amlogic,scpi into the common arm,scpi json scheme. > > > > Couple of things to note: > > "amlogic,meson-gxbb-scpi" is always used with "arm,scpi-pre-1.0" > > hence no need for separate "arm,scpi-pre-1.0" standalone entry and > > "amlogic,meson-gxbb-scpi-sensors" is used always with "arm,scpi-sensors" > > > > Cc: Rob Herring > > Cc: Kevin Hilman > > Cc: Neil Armstrong > > Cc: Jerome Brunet > > Signed-off-by: Sudeep Holla > > --- > > .../devicetree/bindings/arm/amlogic,scpi.txt | 15 --------------- > > .../devicetree/bindings/firmware/arm,scpi.yaml | 4 ++++ > > 2 files changed, 4 insertions(+), 15 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > > > diff --git a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt b/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > deleted file mode 100644 > > index ebfe302fb747..000000000000 > > --- a/Documentation/devicetree/bindings/arm/amlogic,scpi.txt > > +++ /dev/null > > @@ -1,15 +0,0 @@ > > -System Control and Power Interface (SCPI) Message Protocol > > -(in addition to the standard binding in [0]) > > ----------------------------------------------------------- > > -Required properties > > - > > -- compatible : should be "amlogic,meson-gxbb-scpi" > > - > > -Sensor bindings for the sensors based on SCPI Message Protocol > > --------------------------------------------------------------- > > -SCPI provides an API to access the various sensors on the SoC. > > - > > -Required properties: > > -- compatible : should be "amlogic,meson-gxbb-scpi-sensors". > > - > > -[0] Documentation/devicetree/bindings/arm/arm,scpi.txt > > diff --git a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > index 9c115e9c1536..d1179a4ea4e9 100644 > > --- a/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > +++ b/Documentation/devicetree/bindings/firmware/arm,scpi.yaml > > @@ -34,6 +34,7 @@ description: | > > to SCPI v1.0 > > items: > > - const: arm,scpi-pre-1.0 > > + - const: amlogic,meson-gxbb-scpi > > This says that compatible should be: "arm,scpi-pre-1.0", "amlogic,meson-gxbb-scpi" > > The order would be wrong and you lost supporting 'arm,scpi-pre-1.0' by > itself. You want an enum here if it is either one or another items list > if it is 2 entries. > Ah right, I checked about the order and then forgot to update. The idea when I wrote this was not to support arm,scpi-pre-1.0 by itself but recent found some other user of SCPI binding. I better keep the support though it is not in upstream DTS. -- Regards, Sudeep