From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Joakim Zhang <qiangqing.zhang@nxp.com>
Cc: davem@davemloft.net, kuba@kernel.org, robh+dt@kernel.org,
andrew@lunn.ch, hkallweit1@gmail.com, f.fainelli@gmail.com,
linux-imx@nxp.com, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 3/4] net: phy: realteck: add dt property to disable ALDPS mode
Date: Tue, 1 Jun 2021 12:52:19 +0100 [thread overview]
Message-ID: <20210601115219.GU30436@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210601090408.22025-4-qiangqing.zhang@nxp.com>
On Tue, Jun 01, 2021 at 05:04:07PM +0800, Joakim Zhang wrote:
> @@ -325,8 +329,10 @@ static int rtl8211f_config_init(struct phy_device *phydev)
> u16 val;
> int ret;
>
> - val = RTL8211F_ALDPS_ENABLE | RTL8211F_ALDPS_PLL_OFF | RTL8211F_ALDPS_XTAL_OFF;
> - phy_modify_paged_changed(phydev, 0xa43, RTL8211F_PHYCR1, val, val);
> + if (!(priv->quirks & RTL821X_ALDPS_DISABLE_FEATURE)) {
> + val = RTL8211F_ALDPS_ENABLE | RTL8211F_ALDPS_PLL_OFF | RTL8211F_ALDPS_XTAL_OFF;
> + phy_modify_paged_changed(phydev, 0xa43, RTL8211F_PHYCR1, val, val);
> + }
Similar questions as with the previous patch, but also... this doesn't
actually disable the feature if it was previously turned on. E.g. a
kexec() from a current kernel that has set these features into a
subsequent kernel that the DT requests the feature to be disabled. Or
a boot loader that has enabled this feature.
If DT specifies that this feature is disabled, shouldn't this code be
disabling it explicitly?
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-06-01 11:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-01 9:04 [PATCH net-next 0/4] net: phy: add dt property for realtek phy Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 1/4] dt-bindings: net: add dt binding for realtek rtl82xx phy Joakim Zhang
2021-06-01 13:32 ` Rob Herring
2021-06-02 2:39 ` Andrew Lunn
2021-06-02 3:14 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 2/4] net: phy: realtek: add dt property to disable CLKOUT clock Joakim Zhang
2021-06-01 11:48 ` Russell King (Oracle)
2021-06-02 2:18 ` Joakim Zhang
2021-06-01 22:07 ` Andrew Lunn
2021-06-02 2:23 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 3/4] net: phy: realteck: add dt property to disable ALDPS mode Joakim Zhang
2021-06-01 11:52 ` Russell King (Oracle) [this message]
2021-06-02 2:22 ` Joakim Zhang
2021-06-01 9:04 ` [PATCH net-next 4/4] net: phy: realtek: add delay to fix RXC generation issue Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601115219.GU30436@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).