From: Rob Herring <robh@kernel.org>
To: Mark Kettenis <mark.kettenis@xs4all.nl>
Cc: linux-pci@vger.kernel.org, Hector Martin <marcan@marcan.st>,
robin.murphy@arm.com, devicetree@vger.kernel.org,
Mark Kettenis <kettenis@openbsd.org>,
maz@kernel.org, Bjorn Helgaas <bhelgaas@google.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie
Date: Tue, 1 Jun 2021 15:33:14 -0500 [thread overview]
Message-ID: <20210601203314.GA977583@robh.at.kernel.org> (raw)
In-Reply-To: <1622554330.029938.242360.nullmailer@robh.at.kernel.org>
On Tue, Jun 01, 2021 at 08:32:10AM -0500, Rob Herring wrote:
> On Mon, 31 May 2021 00:44:00 +0200, Mark Kettenis wrote:
> > From: Mark Kettenis <kettenis@openbsd.org>
> >
> > The Apple PCIe host controller is a PCIe host controller with
> > multiple root ports present in Apple ARM SoC platforms, including
> > various iPhone and iPad devices and the "Apple Silicon" Macs.
> >
> > Signed-off-by: Mark Kettenis <kettenis@openbsd.org>
> > ---
> > .../devicetree/bindings/pci/apple,pcie.yaml | 167 ++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 168 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/pci/apple,pcie.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> Documentation/devicetree/bindings/pci/apple,pcie.example.dts:20:18: fatal error: dt-bindings/pinctrl/apple.h: No such file or directory
> 20 | #include <dt-bindings/pinctrl/apple.h>
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Looking at the example, I don't think you need this header. Looks like
irq.h is needed though.
Otherwise, LGTM.
Rob
next prev parent reply other threads:[~2021-06-01 20:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-30 22:43 [PATCH v2 0/2] Apple M1 PCIe DT bindings Mark Kettenis
2021-05-30 22:44 ` [PATCH v2 1/2] dt-bindings: pci: Add DT bindings for apple,pcie Mark Kettenis
2021-06-01 13:32 ` Rob Herring
2021-06-01 20:33 ` Rob Herring [this message]
2021-06-02 16:30 ` Mark Kettenis
2021-05-30 22:44 ` [PATCH v2 2/2] arm64: apple: Add PCIe node Mark Kettenis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210601203314.GA977583@robh.at.kernel.org \
--to=robh@kernel.org \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=kettenis@openbsd.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=marcan@marcan.st \
--cc=mark.kettenis@xs4all.nl \
--cc=maz@kernel.org \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).