From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 342D9C4708F for ; Wed, 2 Jun 2021 10:50:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1CB80613B4 for ; Wed, 2 Jun 2021 10:50:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhFBKwG (ORCPT ); Wed, 2 Jun 2021 06:52:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45230 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231488AbhFBKux (ORCPT ); Wed, 2 Jun 2021 06:50:53 -0400 Received: from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com [IPv6:2a00:1450:4864:20::32a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AF0E4C06138E for ; Wed, 2 Jun 2021 03:49:07 -0700 (PDT) Received: by mail-wm1-x32a.google.com with SMTP id m18so996605wmq.0 for ; Wed, 02 Jun 2021 03:49:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=uVBlsRFTHCeuVjtOR8DvHR+ZbSUU8NiMoCv4vvQPWR4=; b=PFKMes1CWeW4Lt7ekTMQhneKZrfRvqa5iHYBdQT0dS8+fFS/W+pLftluaZsbFxlx+0 EF4O43ljaMI4YsjGSOolRDMS1FGAstanDEsaD9mfcrqEdgm4rI5NBCIL3wdo6/wMmCMZ P3LiP0n5bZa6EvAG+Ldcggrn0edt25gvns5JYcXYbXs5r/uli3pj+YIUFzLIayTR7urd awOuCbstqgC9y+8NTSqnvmeCiKinSWCovc3M/M9e0N0qaLzKLlWu6ggkk8aJUmR2bBdy u9nFlBrbl0Dxa5twRixrCfJVs9X1rZzWtOS2hs2+E1yD1HdSircZozbF82C87PTKhFEQ NCog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=uVBlsRFTHCeuVjtOR8DvHR+ZbSUU8NiMoCv4vvQPWR4=; b=tfKFJfUxW9VcspXKAMYp4ffQ571Xq0o2qd8k690W45QKqk9SojeNB0fNIWM7ETIizP S97OuaDfn9+kOFXfNDC/o3AuZdh8PT/wed1ny+5GLQYWI24SkOZEmQCnlrWFGOPGboLY VRJJ/Oa9V8Q1cEXiJLRnT7MdSaAUipmfedImRjAo2mU7bxAVuPmnUYn3nCe6ea95yPhs jzjSMspBKpS7NmB66iRwTjZ5tfcdUbtCodrQNmgj8MWpS1AmREMYVQKKaSRA4LV8E2dF 6U/zePCw3EBtOTqSFW3ebXTq1k6W/nEcHRdRbtQ62r5FuZZmpSSUmwclEvreVy4T3o5f Jp4Q== X-Gm-Message-State: AOAM532lu8ZSlGuvHD+tBvf2q229IfWDEk4iSrTQh6g4R0mi+achG9/D 1JIe/6x5TvNoVzWtnwsxpSHkDw== X-Google-Smtp-Source: ABdhPJzgntdzIWxpFimBaoTHOianeW/vQhWeASnbGWI/4VhnVm0R8ODbgjoEEfwMUS2Fb0yYBN4xsA== X-Received: by 2002:a1c:1dd5:: with SMTP id d204mr4527775wmd.140.1622630946359; Wed, 02 Jun 2021 03:49:06 -0700 (PDT) Received: from dell ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id p20sm2255262wmq.10.2021.06.02.03.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Jun 2021 03:49:05 -0700 (PDT) Date: Wed, 2 Jun 2021 11:49:04 +0100 From: Lee Jones To: Robert Marko Cc: linux-kernel@vger.kernel.org, linus.walleij@linaro.org, bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org, p.zabel@pengutronix.de, robh+dt@kernel.org, devicetree@vger.kernel.org, luka.perkov@sartura.hr, jmp@epiphyte.org, pmenzel@molgen.mpg.de, buczek@molgen.mpg.de Subject: Re: [PATCH v3 1/6] mfd: simple-mfd-i2c: Add Delta TN48M CPLD support Message-ID: <20210602104904.GJ2173308@dell> References: <20210531125143.257622-1-robert.marko@sartura.hr> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210531125143.257622-1-robert.marko@sartura.hr> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 31 May 2021, Robert Marko wrote: 65;6200;1c > Delta TN48M switches have a Lattice CPLD that serves > multiple purposes including being a GPIO expander. > > So, lets use the simple I2C MFD driver to provide the MFD core. > > Also add a virtual symbol which pulls in the simple-mfd-i2c driver and > provide a common symbol on which the subdevice drivers can depend on. > > Signed-off-by: Robert Marko > --- > Changes in v2: > * Drop the custom MFD driver and header > * Use simple I2C MFD driver > > drivers/mfd/Kconfig | 10 ++++++++++ > drivers/mfd/simple-mfd-i2c.c | 1 + > 2 files changed, 11 insertions(+) > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index b74efa469e90..2b5ad314125d 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -297,6 +297,16 @@ config MFD_ASIC3 > This driver supports the ASIC3 multifunction chip found on many > PDAs (mainly iPAQ and HTC based ones) > > +config MFD_TN48M_CPLD > + tristate "Delta Networks TN48M switch CPLD driver" > + depends on I2C > + select MFD_SIMPLE_MFD_I2C > + help > + Select this option to enable support for Delta Networks TN48M switch > + CPLD. It consists of MFD and GPIO drivers. CPLD provides GPIOS-s Not entirely sure what MFD means in this context. Please replace the MFD mention with Reset. > + for the SFP slots as well as power supply related information. > + SFP support depends on the GPIO driver being selected. > + > config PMIC_DA903X > bool "Dialog Semiconductor DA9030/DA9034 PMIC Support" > depends on I2C=y > diff --git a/drivers/mfd/simple-mfd-i2c.c b/drivers/mfd/simple-mfd-i2c.c > index 87f684cff9a1..af8e91781417 100644 > --- a/drivers/mfd/simple-mfd-i2c.c > +++ b/drivers/mfd/simple-mfd-i2c.c > @@ -39,6 +39,7 @@ static int simple_mfd_i2c_probe(struct i2c_client *i2c) > > static const struct of_device_id simple_mfd_i2c_of_match[] = { > { .compatible = "kontron,sl28cpld" }, > + { .compatible = "delta,tn48m-cpld" }, > {} > }; > MODULE_DEVICE_TABLE(of, simple_mfd_i2c_of_match); Once fixed, please apply my: For my own reference (apply this as-is to your sign-off block): Acked-for-MFD-by: Lee Jones -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog