* [PATCH v3 1/2] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema
2021-06-01 5:44 [PATCH v3 0/2] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Lokesh Vutla
@ 2021-06-01 5:44 ` Lokesh Vutla
2021-06-02 19:35 ` Rob Herring
2021-06-01 5:44 ` [PATCH v3 2/2] dt-bindings: pwm: pwm-tiehrpwm: Add compatible string for AM64 SoC Lokesh Vutla
2021-06-04 9:48 ` [PATCH v3 0/2] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Thierry Reding
2 siblings, 1 reply; 6+ messages in thread
From: Lokesh Vutla @ 2021-06-01 5:44 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, Rob Herring
Cc: tony, Vignesh R, Nishanth Menon, linux-pwm,
Device Tree Mailing List, Linux ARM Mailing List,
Linux OMAP Mailing List, Grygorii Strashko, Lokesh Vutla
Convert the tiehrpwm binding to DT schema format using json-schema.
Along with this conversion the following changes are included:
- 'clock' and 'clock-names' properties are marked as required as
driver fails to probe without these properties
- Dropped ti,am33xx-ehrpwm as it is no longer applicable.
- 'power-domains' property is introduced and marked as optional.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
.../devicetree/bindings/pwm/pwm-tiehrpwm.txt | 50 ---------------
.../devicetree/bindings/pwm/pwm-tiehrpwm.yaml | 64 +++++++++++++++++++
2 files changed, 64 insertions(+), 50 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
deleted file mode 100644
index c7e28f6d28be..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.txt
+++ /dev/null
@@ -1,50 +0,0 @@
-TI SOC EHRPWM based PWM controller
-
-Required properties:
-- compatible: Must be "ti,<soc>-ehrpwm".
- for am33xx - compatible = "ti,am3352-ehrpwm", "ti,am33xx-ehrpwm";
- for am4372 - compatible = "ti,am4372-ehrpwm", "ti-am3352-ehrpwm", "ti,am33xx-ehrpwm";
- for am654 - compatible = "ti,am654-ehrpwm", "ti-am3352-ehrpwm";
- for da850 - compatible = "ti,da850-ehrpwm", "ti-am3352-ehrpwm", "ti,am33xx-ehrpwm";
- for dra746 - compatible = "ti,dra746-ehrpwm", "ti-am3352-ehrpwm";
-- #pwm-cells: should be 3. See pwm.yaml in this directory for a description of
- the cells format. The only third cell flag supported by this binding is
- PWM_POLARITY_INVERTED.
-- reg: physical base address and size of the registers map.
-
-Optional properties:
-- clocks: Handle to the PWM's time-base and functional clock.
-- clock-names: Must be set to "tbclk" and "fck".
-
-Example:
-
-ehrpwm0: pwm@48300200 { /* EHRPWM on am33xx */
- compatible = "ti,am3352-ehrpwm", "ti,am33xx-ehrpwm";
- #pwm-cells = <3>;
- reg = <0x48300200 0x100>;
- clocks = <&ehrpwm0_tbclk>, <&l4ls_gclk>;
- clock-names = "tbclk", "fck";
-};
-
-ehrpwm0: pwm@48300200 { /* EHRPWM on am4372 */
- compatible = "ti,am4372-ehrpwm", "ti,am3352-ehrpwm", "ti,am33xx-ehrpwm";
- #pwm-cells = <3>;
- reg = <0x48300200 0x80>;
- clocks = <&ehrpwm0_tbclk>, <&l4ls_gclk>;
- clock-names = "tbclk", "fck";
- ti,hwmods = "ehrpwm0";
-};
-
-ehrpwm0: pwm@1f00000 { /* EHRPWM on da850 */
- compatible = "ti,da850-ehrpwm", "ti,am3352-ehrpwm", "ti,am33xx-ehrpwm";
- #pwm-cells = <3>;
- reg = <0x1f00000 0x2000>;
-};
-
-ehrpwm0: pwm@4843e200 { /* EHRPWM on dra746 */
- compatible = "ti,dra746-ehrpwm", "ti,am3352-ehrpwm";
- #pwm-cells = <3>;
- reg = <0x4843e200 0x80>;
- clocks = <&ehrpwm0_tbclk>, <&l4_root_clk_div>;
- clock-names = "tbclk", "fck";
-};
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
new file mode 100644
index 000000000000..84a8d6d38cee
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
@@ -0,0 +1,64 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-tiehrpwm.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI SOC EHRPWM based PWM controller
+
+maintainers:
+ - Vignesh R <vigneshr@ti.com>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - const: ti,am3352-ehrpwm
+ - items:
+ - enum:
+ - ti,da850-ehrpwm
+ - ti,am4372-ehrpwm
+ - ti,dra746-ehrpwm
+ - ti,am654-ehrpwm
+ - const: ti,am3352-ehrpwm
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 3
+ description: |
+ See pwm.yaml in this directory for a description of the cells format.
+ The only third cell flag supported by this binding is PWM_POLARITY_INVERTED.
+
+ clock-names:
+ items:
+ - const: tbclk
+ - const: fck
+
+ clocks:
+ maxItems: 2
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - "#pwm-cells"
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ ehrpwm0: pwm@48300200 { /* EHRPWM on am33xx */
+ compatible = "ti,am3352-ehrpwm";
+ #pwm-cells = <3>;
+ reg = <0x48300200 0x100>;
+ clocks = <&ehrpwm0_tbclk>, <&l4ls_gclk>;
+ clock-names = "tbclk", "fck";
+ };
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v3 2/2] dt-bindings: pwm: pwm-tiehrpwm: Add compatible string for AM64 SoC
2021-06-01 5:44 [PATCH v3 0/2] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Lokesh Vutla
2021-06-01 5:44 ` [PATCH v3 1/2] " Lokesh Vutla
@ 2021-06-01 5:44 ` Lokesh Vutla
2021-06-02 19:35 ` Rob Herring
2021-06-04 9:48 ` [PATCH v3 0/2] dt-bindings: pwm: pwm-tiehrpwm: Convert to json schema Thierry Reding
2 siblings, 1 reply; 6+ messages in thread
From: Lokesh Vutla @ 2021-06-01 5:44 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, Rob Herring
Cc: tony, Vignesh R, Nishanth Menon, linux-pwm,
Device Tree Mailing List, Linux ARM Mailing List,
Linux OMAP Mailing List, Grygorii Strashko, Lokesh Vutla
Add compatible string for AM64 SoC in device tree binding.
EPWM IP in AM64 does not support High resolution, so named epwm instead
of ehrpwm in compatible. However IP is till compatible with features
supported by driver with ti,am3352-ehrpwm compatible.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
index 84a8d6d38cee..ee312cb210e6 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiehrpwm.yaml
@@ -22,6 +22,7 @@ properties:
- ti,am4372-ehrpwm
- ti,dra746-ehrpwm
- ti,am654-ehrpwm
+ - ti,am64-epwm
- const: ti,am3352-ehrpwm
reg:
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread