devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Suman Anna <s-anna@ti.com>
Cc: devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
	Jan Kiszka <jan.kiszka@siemens.com>,
	linux-arm-kernel@lists.infradead.org,
	Jassi Brar <jaswinder.singh@linaro.org>,
	Tony Lindgren <tony@atomide.com>, Nishanth Menon <nm@ti.com>,
	linux-omap@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML
Date: Wed, 2 Jun 2021 14:45:19 -0500	[thread overview]
Message-ID: <20210602194519.GA3862952@robh.at.kernel.org> (raw)
In-Reply-To: <20210520234348.4479-1-s-anna@ti.com>

On Thu, 20 May 2021 18:43:48 -0500, Suman Anna wrote:
> Convert the current OMAP Mailbox binding from text format to YAML
> format/DT schema, and delete the legacy text binding file.
> 
> The new YAML binding conversion is an updated version compared to
> the original. The descriptions for certain properties have been
> improved to provide more clarity. Constraints are added to the
> properties 'ti,mbox-num-users', 'ti,mbox-num-fifos' and 'interrupts'.
> The 'ti,hwmods' is a legacy property and is retained only to reflect
> the existing usage on some older OMAP2 and OMAP3 platforms.
> 
> All the existing examples have also been updated to reflect the
> latest dts nodes (ti,hwmods removed from OMAP4 and AM33xx examples,
> and interrupts value updated for AM65x SoCs).
> 
> Signed-off-by: Suman Anna <s-anna@ti.com>
> ---
> v2: Address Rob's comments
>  - Replace definitions with $defs
>  - Dropping the trailing | character after all description keywords
>  - Marked ti,hwmods as deprecated
>  - Updated #mbox-cells description
> v1:
> http://patchwork.ozlabs.org/project/devicetree-bindings/patch/20210518172022.10562-1-s-anna@ti.com/
> 
> Note that this would continue to generate the checkpatch warning
> "DT binding docs and includes should be a separate patch" for the
> deleted text file. The fixes for dtbs_check warnings on mailbox nodes
> with this yaml file are posted as well, please see v1 patch for links.
> 
> regards
> Suman
> 
>  .../bindings/mailbox/omap-mailbox.txt         | 184 -----------
>  .../bindings/mailbox/ti,omap-mailbox.yaml     | 308 ++++++++++++++++++
>  2 files changed, 308 insertions(+), 184 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/mailbox/omap-mailbox.txt
>  create mode 100644 Documentation/devicetree/bindings/mailbox/ti,omap-mailbox.yaml
> 

Applied, thanks!

      parent reply	other threads:[~2021-06-02 19:45 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-20 23:43 [PATCH v2] dt-bindings: mailbox: Convert omap-mailbox.txt binding to YAML Suman Anna
2021-05-28 15:00 ` Suman Anna
2021-06-02 19:45 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210602194519.GA3862952@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jan.kiszka@siemens.com \
    --cc=jaswinder.singh@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=s-anna@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).