From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92119C07E94 for ; Fri, 4 Jun 2021 13:24:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6B8C5613F9 for ; Fri, 4 Jun 2021 13:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230502AbhFDN0j (ORCPT ); Fri, 4 Jun 2021 09:26:39 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:51943 "EHLO mail-wm1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230110AbhFDN0j (ORCPT ); Fri, 4 Jun 2021 09:26:39 -0400 Received: by mail-wm1-f47.google.com with SMTP id r13so5388095wmq.1 for ; Fri, 04 Jun 2021 06:24:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=+sT4YYKrQb2O5xI5wztXIAWtyacTFced2VFE4TLIp60=; b=ySiUwhYzsJGSzp36XB999q1MbEQ96sQpPPHULrfsaUm/LbNGHvntoy9xwDR6LnPxFI aaQlYLo5tfvAVdcsrADn6mrXtmvuH1RhsIXzPpuVQ81Y34PPKUUMjxj491nxsKp/pcy8 NrdQ6Syy/jwbcbdTdrCoZFjqcj61qpvaKhtZFcOd9wi2sOL+LpwY+SoXdtHyRliKS44L RjqSzzMX2GPQsCTYaH1uxRBoEDqGbHUXXwHtHcYyrEcCdA+oykyyoGlhXr5lyk2A2Hvj MrW+27uUG7L6hy2QSqWEG7VTQqSUi61G9XuX7+Dbr1sw5YISsiT7dD7FWd0pe/T9dEqw 7y7A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=+sT4YYKrQb2O5xI5wztXIAWtyacTFced2VFE4TLIp60=; b=QIl2EAHdNn9PRGJYt2Pj7Yb1KsvqxmBEd8hBXZZu5SdIniPQea8OGcH8vyWjkalPdH b442TLxUl1QWzaWzAyTvVIjVD9QiqRrTBCtx1SVvNqR6Ou8KsCBqfMi848PMmnCILy9l fMRntKAWRAEAr13UBXIaXmBZh4CEHag77FpfwBry35B4bJQAeoRxogE65AVjgTw6RiCW P+m/OF9ZXyn8Idb9hGKavGfI51E6jY+Tm5D8+vO5krP2O5n60obja+XAyEs/gI/kG7/P ic9RiNtkQUODdMcZT0nzvUdUytWnQ8LJxoUayOY2WiFHidWCrN6YEK3H9+ujX6Ko3OMD RIrw== X-Gm-Message-State: AOAM530mS9NS/+RgB887IrHMP/nb3ZLQzo+EsSccvD/SXJobjopp06or ZVbDCJEMdZm+KDPb0PRk9Lxvqw== X-Google-Smtp-Source: ABdhPJyIXvaJGxAIuz9G9hqzr6MEeZebOlfx+GRaCsLAzvjVFcJ2FSSUkUHrMgXxV8y2OfWOc6gC0w== X-Received: by 2002:a1c:2805:: with SMTP id o5mr3625525wmo.103.1622813018831; Fri, 04 Jun 2021 06:23:38 -0700 (PDT) Received: from dell ([91.110.221.214]) by smtp.gmail.com with ESMTPSA id q11sm5752457wmq.1.2021.06.04.06.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 06:23:38 -0700 (PDT) Date: Fri, 4 Jun 2021 14:23:35 +0100 From: Lee Jones To: Wendell Lin Cc: Stephen Boyd , Matthias Brugger , Michael Turquette , linux-clk , open list , ARM/Mediatek SoC support , linux-arm-kernel , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , wsd_upstream Subject: Re: [PATCH 1/1] clk: Export clk_register_composite Message-ID: <20210604132335.GK2435141@dell> References: <1595493126-21611-1-git-send-email-wendell.lin@mediatek.com> <1597052186.27843.1.camel@mtkswgap22> <162276982204.1835121.10976600065855289763@swboyd.mtv.corp.google.com> <20210604082427.GE2435141@dell> <20210604082524.GF2435141@dell> <1622802121.26830.22.camel@mtkswgap22> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1622802121.26830.22.camel@mtkswgap22> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 04 Jun 2021, Wendell Lin wrote: > On Fri, 2021-06-04 at 09:25 +0100, Lee Jones wrote: > > On Fri, 04 Jun 2021, Lee Jones wrote: > > > > > On Thu, 03 Jun 2021, Stephen Boyd wrote: > > > > > > > Quoting Lee Jones (2021-05-20 09:07:42) > > > > > On Mon, 10 Aug 2020 at 10:36, Wendell Lin wrote: > > > > > > > > > > Hi Matthias and all, > > > > > > > > > > Gentle ping on this patch. > > > > > > > > > > > > > > > What about a not-so-gentle ping on this patch? Grrrr... :) > > > > > > > > > > FYI, this is still required by more than one source. > > > > > > > > > > Please help get this out of all of the vendor trees please. > > > > > > > > > > > > > Is there an in-kernel user? > > > > > > How can there be? It's not exported yet. :) > > > > > > However there shouldn't be any barriers for vendors represented in > > > Mainline to build their drivers as modules if they so wish. If/when > > > they do, this will need to be exported. > > > > Wendell Lin, is this what you wish to do with the in-kernel MediaTek > > driver? > > > This is because Mediatek clock driver would be built as kernel module, > so clk_register_composite() used should be exported, then we could use > it. > > Please refer: > [PATCH 2/2] clk: mediatek: Add EXPORT_SYMBOL for kernel module support > https://lkml.org/lkml/2020/7/1/124 > +EXPORT_SYMBOL(mtk_clk_register_composites); > > clk_register_composite() is used by Mediatek clk kernel module. > From export symbol: mtk_clk_register_composites. Perfect. Thanks for the clarification. Anything else you need from us Stephen? -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog