* [PATCH 1/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema
2021-06-01 10:28 [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema Lokesh Vutla
@ 2021-06-01 10:28 ` Lokesh Vutla
2021-06-04 21:49 ` Rob Herring
2021-06-01 10:28 ` [PATCH 2/2] dt-bindings: pwm: pwm-tiecap: Add compatible string for AM64 SoC Lokesh Vutla
2021-06-21 11:53 ` [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema Lokesh Vutla
2 siblings, 1 reply; 6+ messages in thread
From: Lokesh Vutla @ 2021-06-01 10:28 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, Rob Herring
Cc: tony, Vignesh R, Nishanth Menon, linux-pwm,
Device Tree Mailing List, Linux ARM Mailing List,
Linux OMAP Mailing List, Grygorii Strashko, Lokesh Vutla
Convert the tiecap binding to DT schema format using json-schema.
Along with this conversion the following changes are included:
- 'clock' and 'clock-names' properties are marked required as
driver fails to probe without these properties
- Dropped ti,am33xx-ecap as it is no longer applicable.
- 'power-domains' property is introduced and marked as optional.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
.../devicetree/bindings/pwm/pwm-tiecap.txt | 51 ---------------
.../devicetree/bindings/pwm/pwm-tiecap.yaml | 63 +++++++++++++++++++
2 files changed, 63 insertions(+), 51 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt b/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
deleted file mode 100644
index c7c4347a769a..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
+++ /dev/null
@@ -1,51 +0,0 @@
-TI SOC ECAP based APWM controller
-
-Required properties:
-- compatible: Must be "ti,<soc>-ecap".
- for am33xx - compatible = "ti,am3352-ecap", "ti,am33xx-ecap";
- for am4372 - compatible = "ti,am4372-ecap", "ti,am3352-ecap", "ti,am33xx-ecap";
- for da850 - compatible = "ti,da850-ecap", "ti,am3352-ecap", "ti,am33xx-ecap";
- for dra746 - compatible = "ti,dra746-ecap", "ti,am3352-ecap";
- for 66ak2g - compatible = "ti,k2g-ecap", "ti,am3352-ecap";
- for am654 - compatible = "ti,am654-ecap", "ti,am3352-ecap";
-- #pwm-cells: should be 3. See pwm.yaml in this directory for a description of
- the cells format. The PWM channel index ranges from 0 to 4. The only third
- cell flag supported by this binding is PWM_POLARITY_INVERTED.
-- reg: physical base address and size of the registers map.
-
-Optional properties:
-- clocks: Handle to the ECAP's functional clock.
-- clock-names: Must be set to "fck".
-
-Example:
-
-ecap0: ecap@48300100 { /* ECAP on am33xx */
- compatible = "ti,am3352-ecap", "ti,am33xx-ecap";
- #pwm-cells = <3>;
- reg = <0x48300100 0x80>;
- clocks = <&l4ls_gclk>;
- clock-names = "fck";
-};
-
-ecap0: ecap@48300100 { /* ECAP on am4372 */
- compatible = "ti,am4372-ecap", "ti,am3352-ecap", "ti,am33xx-ecap";
- #pwm-cells = <3>;
- reg = <0x48300100 0x80>;
- ti,hwmods = "ecap0";
- clocks = <&l4ls_gclk>;
- clock-names = "fck";
-};
-
-ecap0: ecap@1f06000 { /* ECAP on da850 */
- compatible = "ti,da850-ecap", "ti,am3352-ecap", "ti,am33xx-ecap";
- #pwm-cells = <3>;
- reg = <0x1f06000 0x80>;
-};
-
-ecap0: ecap@4843e100 {
- compatible = "ti,dra746-ecap", "ti,am3352-ecap";
- #pwm-cells = <3>;
- reg = <0x4843e100 0x80>;
- clocks = <&l4_root_clk_div>;
- clock-names = "fck";
-};
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
new file mode 100644
index 000000000000..8717166dd05f
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
@@ -0,0 +1,63 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-tiecap.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: TI SOC ECAP based APWM controller
+
+maintainers:
+ - Vignesh R <vigneshr@ti.com>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ oneOf:
+ - const: ti,am3352-ecap
+ - items:
+ - enum:
+ - ti,da850-ecap
+ - ti,am4372-ecap
+ - ti,dra746-ecap
+ - ti,k2g-ecap
+ - ti,am654-ecap
+ - const: ti,am3352-ecap
+
+ reg:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 3
+ description: |
+ See pwm.yaml in this directory for a description of the cells format.
+ The only third cell flag supported by this binding is PWM_POLARITY_INVERTED.
+
+ clock-names:
+ const: fck
+
+ clocks:
+ maxItems: 1
+
+ power-domains:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+ - "#pwm-cells"
+ - clocks
+ - clock-names
+
+additionalProperties: false
+
+examples:
+ - |
+ ecap0: pwm@48300100 { /* ECAP on am33xx */
+ compatible = "ti,am3352-ecap";
+ #pwm-cells = <3>;
+ reg = <0x48300100 0x80>;
+ clocks = <&l4ls_gclk>;
+ clock-names = "fck";
+ };
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] dt-bindings: pwm: pwm-tiecap: Add compatible string for AM64 SoC
2021-06-01 10:28 [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema Lokesh Vutla
2021-06-01 10:28 ` [PATCH 1/2] " Lokesh Vutla
@ 2021-06-01 10:28 ` Lokesh Vutla
2021-06-04 21:49 ` Rob Herring
2021-06-21 11:53 ` [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema Lokesh Vutla
2 siblings, 1 reply; 6+ messages in thread
From: Lokesh Vutla @ 2021-06-01 10:28 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, Rob Herring
Cc: tony, Vignesh R, Nishanth Menon, linux-pwm,
Device Tree Mailing List, Linux ARM Mailing List,
Linux OMAP Mailing List, Grygorii Strashko, Lokesh Vutla
Add compatible string for AM64 SoC in device tree binding.
IP is compatible with ti,am3352-ecap, so adding the AM64 compatible
under enum of one of the compatible list entry.
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
index 8717166dd05f..ed35b6cc48d5 100644
--- a/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
+++ b/Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
@@ -23,6 +23,7 @@ properties:
- ti,dra746-ecap
- ti,k2g-ecap
- ti,am654-ecap
+ - ti,am64-ecap
- const: ti,am3352-ecap
reg:
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema
2021-06-01 10:28 [PATCH 0/2] dt-bindings: pwm: pwm-tiecap: Convert to json schema Lokesh Vutla
2021-06-01 10:28 ` [PATCH 1/2] " Lokesh Vutla
2021-06-01 10:28 ` [PATCH 2/2] dt-bindings: pwm: pwm-tiecap: Add compatible string for AM64 SoC Lokesh Vutla
@ 2021-06-21 11:53 ` Lokesh Vutla
2 siblings, 0 replies; 6+ messages in thread
From: Lokesh Vutla @ 2021-06-21 11:53 UTC (permalink / raw)
To: thierry.reding, u.kleine-koenig, lee.jones, Rob Herring
Cc: tony, Vignesh R, Nishanth Menon, linux-pwm,
Device Tree Mailing List, Linux ARM Mailing List,
Linux OMAP Mailing List, Grygorii Strashko
Hi Thierry,
On 01/06/21 3:58 pm, Lokesh Vutla wrote:
> This series:
> - converts tiecap to DT schema format using json-schema
> - Add new compatible for AM64 SoC.
If there are no objections, can we merge this series?
Thanks and regards,
Lokesh
>
> Lokesh Vutla (2):
> dt-bindings: pwm: pwm-tiecap: Convert to json schema
> dt-bindings: pwm: pwm-tiecap: Add compatible string for AM64 SoC
>
> .../devicetree/bindings/pwm/pwm-tiecap.txt | 51 ---------------
> .../devicetree/bindings/pwm/pwm-tiecap.yaml | 64 +++++++++++++++++++
> 2 files changed, 64 insertions(+), 51 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiecap.txt
> create mode 100644 Documentation/devicetree/bindings/pwm/pwm-tiecap.yaml
>
^ permalink raw reply [flat|nested] 6+ messages in thread