Re: [PATCH V2 1/2] dt-bindings: arm: ti: Add bindings for J721E EAIK

Sinthu Raja M
2021-06-07T17:25:24Z

On Mon, Jun 7, 2021 at 7:02 PM Nishanth Menon <nm@ti.com> wrote:
>
> On 15:03-20210607, Sinthu Raja wrote:
> > From: Sinthu Raja <sinthu.raja@ti.com>
> >
> > J721E EdgeAI Kit (EAIK) is a low cost, small form factor board designed
> > for TI’s J721E SoC.
> > Add DT binding documentation for J721E EAIK
>
> Need a url for the board.
The URL for the board is not available until the board launch.
Probably should have mentioned in the cover letter.
>
> >
> > Signed-off-by: Amarnath MB <amarnath.mb@ti.com>
> > Signed-off-by: Sinthu Raja <sinthu.raja@ti.com>
> > ---
> > Change in V2:
> > - Fix for dt_binding_check error.
> >
> > Documentation/devicetree/bindings/arm/ti/k3.yaml | 2 ++
> > .../devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml | 2 +-
> > 2 files changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/ti/k3.yaml b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > index c5aa362e4026..923dd7cf1dc6 100644
> > --- a/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > +++ b/Documentation/devicetree/bindings/arm/ti/k3.yaml
> > @@ -29,6 +29,8 @@ properties:
> >
> > - description: K3 J721E SoC
> > items:
> > + - enum:
> > + - ti,j721e-eaik
> > - const: ti,j721e
> >
> > - description: K3 J7200 SoC
> > diff --git a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> > index 6070456a7b67..464cee128811 100644
> > --- a/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> > +++ b/Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> > @@ -135,7 +135,7 @@ examples:
> > - |
> > / {
> > model = "Texas Instruments K3 J721E SoC";
> > - compatible = "ti,j721e";
> > + compatible = "ti,j721e-eaik", "ti,j721e";
> I see what we are attempting to do here.
>
> Documentation/devicetree/bindings/remoteproc/ti,k3-dsp-rproc.yaml
> probably should strip off the board specifics out in the
> examples. but, that belongs to a different patch.
Will remove this change. But do we need to ignore the dt_binding
_check for this patch series?

Regards
Sinthu Raja