* [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
@ 2021-06-02 20:37 Marek Vasut
2021-06-10 18:11 ` Rob Herring
2021-06-14 18:09 ` Laurent Pinchart
0 siblings, 2 replies; 4+ messages in thread
From: Marek Vasut @ 2021-06-02 20:37 UTC (permalink / raw)
To: dri-devel
Cc: ch, Marek Vasut, Laurent Pinchart, Rob Herring, Sam Ravnborg,
devicetree
Decoder input LVDS format is a property of the decoder chip or even
its strapping. Add DT property data-mapping the same way lvds-panel
does, to define the LVDS data mapping.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
V2: - Use allOf
- Move the data-mapping to endpoint
---
.../bindings/display/bridge/lvds-codec.yaml | 53 ++++++++++++++-----
1 file changed, 41 insertions(+), 12 deletions(-)
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index cacafa61e3f52..c493d007785ca 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -68,6 +68,18 @@ properties:
For LVDS encoders, port 1 is the LVDS output
For LVDS decoders, port 1 is the parallel output
+ properties:
+ endpoint:
+ properties:
+ data-mapping:
+ enum:
+ - jeida-18
+ - jeida-24
+ - vesa-24
+ description: |
+ The color signals mapping order. See details in
+ Documentation/devicetree/bindings/display/panel/lvds.yaml
+
required:
- port@0
- port@1
@@ -79,21 +91,38 @@ properties:
power-supply: true
-if:
- not:
- properties:
- compatible:
- contains:
- const: lvds-encoder
-then:
- properties:
- ports:
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: lvds-encoder
+ then:
+ properties:
+ ports:
+ properties:
+ port@0:
+ properties:
+ endpoint:
+ properties:
+ pclk-sample: false
+
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: lvds-decoder
+ then:
properties:
- port@0:
+ ports:
properties:
- endpoint:
+ port@1:
properties:
- pclk-sample: false
+ endpoint:
+ properties:
+ data-mapping: false
required:
- compatible
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
2021-06-02 20:37 [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
@ 2021-06-10 18:11 ` Rob Herring
2021-06-14 18:09 ` Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Rob Herring @ 2021-06-10 18:11 UTC (permalink / raw)
To: Marek Vasut
Cc: devicetree, Rob Herring, Sam Ravnborg, Laurent Pinchart,
dri-devel, ch
On Wed, 02 Jun 2021 22:37:30 +0200, Marek Vasut wrote:
> Decoder input LVDS format is a property of the decoder chip or even
> its strapping. Add DT property data-mapping the same way lvds-panel
> does, to define the LVDS data mapping.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: - Use allOf
> - Move the data-mapping to endpoint
> ---
> .../bindings/display/bridge/lvds-codec.yaml | 53 ++++++++++++++-----
> 1 file changed, 41 insertions(+), 12 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
2021-06-02 20:37 [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
2021-06-10 18:11 ` Rob Herring
@ 2021-06-14 18:09 ` Laurent Pinchart
1 sibling, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2021-06-14 18:09 UTC (permalink / raw)
To: Marek Vasut; +Cc: dri-devel, ch, Rob Herring, Sam Ravnborg, devicetree
Hi Marek,
Thank you for the patch.
On Wed, Jun 02, 2021 at 10:37:30PM +0200, Marek Vasut wrote:
> Decoder input LVDS format is a property of the decoder chip or even
> its strapping. Add DT property data-mapping the same way lvds-panel
> does, to define the LVDS data mapping.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> Cc: devicetree@vger.kernel.org
> To: dri-devel@lists.freedesktop.org
> ---
> V2: - Use allOf
> - Move the data-mapping to endpoint
> ---
> .../bindings/display/bridge/lvds-codec.yaml | 53 ++++++++++++++-----
> 1 file changed, 41 insertions(+), 12 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> index cacafa61e3f52..c493d007785ca 100644
> --- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
> @@ -68,6 +68,18 @@ properties:
> For LVDS encoders, port 1 is the LVDS output
> For LVDS decoders, port 1 is the parallel output
>
> + properties:
> + endpoint:
> + properties:
> + data-mapping:
> + enum:
> + - jeida-18
> + - jeida-24
> + - vesa-24
> + description: |
> + The color signals mapping order. See details in
> + Documentation/devicetree/bindings/display/panel/lvds.yaml
> +
> required:
> - port@0
> - port@1
> @@ -79,21 +91,38 @@ properties:
>
> power-supply: true
>
> -if:
> - not:
> - properties:
> - compatible:
> - contains:
> - const: lvds-encoder
> -then:
> - properties:
> - ports:
> +allOf:
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: lvds-encoder
> + then:
> + properties:
> + ports:
> + properties:
> + port@0:
> + properties:
> + endpoint:
> + properties:
> + pclk-sample: false
> +
> + - if:
> + not:
> + properties:
> + compatible:
> + contains:
> + const: lvds-decoder
Is this correct ? The condition says that if it's an encoder (not a
decoder), then the data-mapping property on port 1 (the output port,
thus and LVDS port) is not allowed. I think this should be for decoders,
not encoders. You can thus combine the two conditions:
allOf:
- if:
not:
properties:
compatible:
contains:
const: lvds-encoder
then:
properties:
ports:
properties:
port@0:
properties:
endpoint:
properties:
pclk-sample: false
port@1:
properties:
endpoint:
properties:
data-mapping: false
You could also drop the allOf, or keep it to avoid whitespace churn when
a new condition will need to be added.
> + then:
> properties:
> - port@0:
> + ports:
> properties:
> - endpoint:
> + port@1:
> properties:
> - pclk-sample: false
> + endpoint:
> + properties:
> + data-mapping: false
>
> required:
> - compatible
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select
@ 2021-07-26 20:16 Marek Vasut
0 siblings, 0 replies; 4+ messages in thread
From: Marek Vasut @ 2021-07-26 20:16 UTC (permalink / raw)
To: dri-devel
Cc: Marek Vasut, Laurent Pinchart, Rob Herring, Sam Ravnborg,
devicetree
Decoder input LVDS format is a property of the decoder chip or even
its strapping. Add DT property data-mapping the same way lvds-panel
does, to define the LVDS data mapping.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Sam Ravnborg <sam@ravnborg.org>
Cc: devicetree@vger.kernel.org
To: dri-devel@lists.freedesktop.org
---
V2: Rebase on latest next
---
.../bindings/display/bridge/lvds-codec.yaml | 19 +++++++++++++++++++
1 file changed, 19 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 304a1367faaa7..33e0c08933b72 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -64,6 +64,15 @@ properties:
- port@0
- port@1
+ data-mapping:
+ enum:
+ - jeida-18
+ - jeida-24
+ - vesa-24
+ description: |
+ The color signals mapping order. See details in
+ Documentation/devicetree/bindings/display/panel/lvds.yaml
+
powerdown-gpios:
description:
The GPIO used to control the power down line of this device.
@@ -71,6 +80,16 @@ properties:
power-supply: true
+if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: lvds-decoder
+then:
+ properties:
+ data-mapping: false
+
required:
- compatible
- ports
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-07-26 20:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-02 20:37 [PATCH V2 1/2] dt-bindings: display: bridge: lvds-codec: Document LVDS data mapping select Marek Vasut
2021-06-10 18:11 ` Rob Herring
2021-06-14 18:09 ` Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2021-07-26 20:16 Marek Vasut
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).