From: Nishanth Menon <nm@ti.com>
To: Vignesh Raghavendra <vigneshr@ti.com>
Cc: Lokesh Vutla <lokeshvutla@ti.com>,
Rob Herring <robh+dt@kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
Linux ARM Mailing List <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM
Date: Fri, 11 Jun 2021 14:03:25 -0500 [thread overview]
Message-ID: <20210611190325.6mg4nzhreotsn3db@attribute> (raw)
In-Reply-To: <dd2261dd-8285-5a47-526f-5b9e7056aa84@ti.com>
On 23:59-20210611, Vignesh Raghavendra wrote:
>
>
> On 6/9/21 8:56 PM, Lokesh Vutla wrote:
> >
> >
> > On 09/06/21 7:36 pm, Vignesh Raghavendra wrote:
> >> Last 256K of OCRAM (256K@0x701c0000) is reserved for SYSFW usage. Hence
> >> add an entry in DT so that its not used for generic pool memory
> >> allocation.
> >>
> >> Without this certain drivers using SRAM as generic shared memory pool
> >> may end up being allocated memory from this range and will lead to boot
> >> time crash when the reserved range is accessed (due to firewall
> >> violation).
> >>
> >> Signed-off-by: Vignesh Raghavendra <vigneshr@ti.com>
> >
> > You might want to re-base on top of Aswath's patch updating ATF address. Otherwise:
> >
> > Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
> >
>
> Actually, this patch should go in before Aswath's patch as moving ATF
> location around exposed issue of drivers getting memory allocations
> overlapping SYSFW reserved ranges
I have applied Aswath's patch, please rebase. understood this is a bug,
but either way, it really was'nt a regression of stuff that was present.
please fix and send asap so that I can pick it up.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2021-06-11 19:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-09 14:06 [PATCH] arm64: dts: ti: k3-am64-main: Add SYSFW reserved ranges in OCRAM Vignesh Raghavendra
2021-06-09 15:26 ` Lokesh Vutla
2021-06-11 18:29 ` Vignesh Raghavendra
2021-06-11 19:03 ` Nishanth Menon [this message]
2021-06-11 19:16 ` Nishanth Menon
2021-06-12 7:21 ` Vignesh Raghavendra
2021-06-14 4:48 ` Aswath Govindraju
2021-06-14 14:28 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210611190325.6mg4nzhreotsn3db@attribute \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).