From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC377C48BE6 for ; Sat, 12 Jun 2021 02:11:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 843C8613AA for ; Sat, 12 Jun 2021 02:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229622AbhFLCNE (ORCPT ); Fri, 11 Jun 2021 22:13:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:45998 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229584AbhFLCND (ORCPT ); Fri, 11 Jun 2021 22:13:03 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 7E5DF613A9; Sat, 12 Jun 2021 02:11:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1623463864; bh=PW2CEmSwe+rqFq+AkOuoL5MTOf2oV4ugebD1RL2ZxP0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LyNq0/rRsn6CYRPdq3841ocxrvxc4a9+mB0Y27X/9v1J8VS7vLYmGyEJz0BG5D1iA dpAFe1BH7+CTiiGiCyYD7KR2xYq7mG44sdAdtvnTK/zEm7le8tqlPS4y5AmdIUaIdE XD72apOlmLIgdy7BgPxT1KvEZ9UgTM/Z9f2sfT4W5SBlm/Z75DX8fZzK04iYIvafhN coCqIj0BX5iMtVwhXmN3foeaD5A+aea7SsrKe7/0LiPmfpytoZTGRrVPyfH3IWoNV0 +mZT1ooYh+Hzgvzt8S8TVP1NZb9HdoYPViUz4LbpAVtA/kKxwg1cQMYyR6CCtwLyT2 JAVElWFoOTyDQ== Date: Sat, 12 Jun 2021 10:10:58 +0800 From: Shawn Guo To: "Leizhen (ThunderTown)" Cc: Mark Kettenis , leoyang.li@nxp.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Vabhav Sharma , Russell King Subject: Re: [PATCH 1/1] arm64: dts: lx2160a: Normalize the compatible string of "arm, sbsa-uart" Message-ID: <20210612021057.GE29138@dragon> References: <20210524035244.8677-1-thunder.leizhen@huawei.com> <5612f2cad25a3041@bloch.sibelius.xs4all.nl> <52e44070-3b6f-b8ee-2f23-6059517755a8@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <52e44070-3b6f-b8ee-2f23-6059517755a8@huawei.com> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, May 25, 2021 at 10:00:30AM +0800, Leizhen (ThunderTown) wrote: > > > On 2021/5/25 1:36, Mark Kettenis wrote: > >> From: Zhen Lei > >> Date: Mon, 24 May 2021 11:52:44 +0800 > >> Content-Type: text/plain; charset="us-ascii" > >> > >> The compatible string of ARM SBSA defined generic UART needs to contain > >> only "arm,sbsa-uart" and does not need to contain "arm,pl011". Otherwise, > >> the pl011.yaml will check it and falsely report many warnings similar to > >> the following: > >> > >> arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dt.yaml: > >> serial@21c0000: compatible:0: 'arm,pl011' was expected > >> serial@21c0000: compatible:1: 'arm,primecell' was expected > >> > >> Delete the redundant "arm,pl011" to fix it. > > > > According to its reference manual, the LX2160A has a full PL011 > > implementation. So I think this is the wrong "fix". > > No, No, Please refer: https://www.spinics.net/lists/devicetree/msg424054.html > > Now the "arm,sbsa-uart" driver is mixed with amba-pl011.c，It's impossible > "arm,pl011" is loaded but "arm,sbsa-uart" is not loaded. So it makes no sense > to append "arm, pl011" to the end of the compatible string as an alternative > driver. > > drivers/tty/serial/amba-pl011.c:2784: { .compatible = "arm,sbsa-uart", }, I guess Mark is suggesting the following fix. uart0: serial@21c0000 { - compatible = "arm,sbsa-uart","arm,pl011"; + compatible = "arm,pl011", "arm,primecell"; reg = <0x0 0x21c0000 0x0 0x1000>; interrupts = ; - current-speed = <115200>; status = "disabled"; }; I copied some folks who might help clarify whether LX2160A UART is a SBSA or a full PL011. Shawn > > > > > >> Signed-off-by: Zhen Lei > >> --- > >> arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 8 ++++---- > >> 1 file changed, 4 insertions(+), 4 deletions(-) > >> > >> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> index 4fcc869c21a4..417546616d85 100644 > >> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi > >> @@ -920,7 +920,7 @@ > >> }; > >> > >> uart0: serial@21c0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21c0000 0x0 0x1000>; > >> interrupts = ; > >> current-speed = <115200>; > >> @@ -928,7 +928,7 @@ > >> }; > >> > >> uart1: serial@21d0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21d0000 0x0 0x1000>; > >> interrupts = ; > >> current-speed = <115200>; > >> @@ -936,7 +936,7 @@ > >> }; > >> > >> uart2: serial@21e0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21e0000 0x0 0x1000>; > >> interrupts = ; > >> current-speed = <115200>; > >> @@ -944,7 +944,7 @@ > >> }; > >> > >> uart3: serial@21f0000 { > >> - compatible = "arm,sbsa-uart","arm,pl011"; > >> + compatible = "arm,sbsa-uart"; > >> reg = <0x0 0x21f0000 0x0 0x1000>; > >> interrupts = ; > >> current-speed = <115200>; > >> -- > >> 2.21.1 > >> > >> > >> > >> _______________________________________________ > >> linux-arm-kernel mailing list > >> linux-arm-kernel@lists.infradead.org > >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > >> > > > > . > > >