devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: Add Rotation Property for OGA Panel
@ 2021-06-14 16:18 Chris Morgan
  2021-06-19  8:38 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Chris Morgan @ 2021-06-14 16:18 UTC (permalink / raw)
  To: devicetree; +Cc: robh+dt, heiko, jbx6244, maccraft123mc, Chris Morgan

From: Chris Morgan <macromorgan@hotmail.com>

Add rotation property for Odroid Go Advance panel to note that it is
rotated 270 degrees. Rotation affects DRM connector after this patch:

https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/panel/panel-elida-kd35t133.c?id=610d9c311b1387f8c4ac602fee1f2a1cb0508707

Note: following example of motorola-mapphone-common and
tegra30-asus-nexus7-grouper-common where rotation is specified by
itself with other physical properties (which are already hard-coded
into the driver in this case so not necessary). Please advise if this
is not the correct manner in the devicetree to specify this.

Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
index 49c97f76df77..32d7b8270649 100644
--- a/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3326-odroid-go2.dts
@@ -241,6 +241,8 @@ panel@0 {
 		reset-gpios = <&gpio3 RK_PC0 GPIO_ACTIVE_LOW>;
 		vdd-supply = <&vcc_lcd>;
 
+		rotation = <270>;
+
 		port {
 			mipi_in_panel: endpoint {
 				remote-endpoint = <&mipi_out_panel>;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: Add Rotation Property for OGA Panel
  2021-06-14 16:18 [PATCH] arm64: dts: rockchip: Add Rotation Property for OGA Panel Chris Morgan
@ 2021-06-19  8:38 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2021-06-19  8:38 UTC (permalink / raw)
  To: Chris Morgan, devicetree
  Cc: Heiko Stuebner, robh+dt, jbx6244, maccraft123mc, Chris Morgan

On Mon, 14 Jun 2021 11:18:49 -0500, Chris Morgan wrote:
> Add rotation property for Odroid Go Advance panel to note that it is
> rotated 270 degrees. Rotation affects DRM connector after this patch:
> 
> https://cgit.freedesktop.org/drm/drm/commit/drivers/gpu/drm/panel/panel-elida-kd35t133.c?id=610d9c311b1387f8c4ac602fee1f2a1cb0508707
> 
> Note: following example of motorola-mapphone-common and
> tegra30-asus-nexus7-grouper-common where rotation is specified by
> itself with other physical properties (which are already hard-coded
> into the driver in this case so not necessary). Please advise if this
> is not the correct manner in the devicetree to specify this.

Applied, thanks!
(adapted to property ordering to just follow our alphabetical sorting)

[1/1] arm64: dts: rockchip: Add Rotation Property for OGA Panel
      commit: edb39de5d731f147c7b08c4a5eb246ae1dbdd947

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-06-19  8:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-14 16:18 [PATCH] arm64: dts: rockchip: Add Rotation Property for OGA Panel Chris Morgan
2021-06-19  8:38 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).