From: Daniel Mack <daniel@zonque.org>
To: linux-clk@vger.kernel.org, devicetree@vger.kernel.org
Cc: robh+dt@kernel.org, kuninori.morimoto.gx@renesas.com,
mturquette@baylibre.com, sboyd@kernel.org,
Daniel Mack <daniel@zonque.org>
Subject: [PATCH v3 8/9] clk: cs2000-cp: freeze config during register fiddling
Date: Thu, 17 Jun 2021 21:09:11 +0200 [thread overview]
Message-ID: <20210617190912.262809-9-daniel@zonque.org> (raw)
In-Reply-To: <20210617190912.262809-1-daniel@zonque.org>
Make sure to freeze the configuration of the chip during the programming
of 32-bit registers. This avoids the processing of invalid intermediate
states.
Signed-off-by: Daniel Mack <daniel@zonque.org>
---
drivers/clk/clk-cs2000-cp.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/clk/clk-cs2000-cp.c b/drivers/clk/clk-cs2000-cp.c
index f3093d99c639..a630fb75bd4c 100644
--- a/drivers/clk/clk-cs2000-cp.c
+++ b/drivers/clk/clk-cs2000-cp.c
@@ -52,6 +52,7 @@
#define FRACNSRC_DYNAMIC (1 << 0)
/* GLOBAL_CFG */
+#define FREEZE (1 << 7)
#define ENDEV2 (0x1)
/* FUNC_CFG1 */
@@ -336,6 +337,10 @@ static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
{
int ret;
+ ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, FREEZE);
+ if (ret < 0)
+ return ret;
+
ret = cs2000_select_ratio_mode(priv, rate, parent_rate);
if (ret < 0)
return ret;
@@ -348,6 +353,10 @@ static int __cs2000_set_rate(struct cs2000_priv *priv, int ch,
if (ret < 0)
return ret;
+ ret = cs2000_bset(priv, GLOBAL_CFG, FREEZE, 0);
+ if (ret < 0)
+ return ret;
+
priv->saved_rate = rate;
priv->saved_parent_rate = parent_rate;
--
2.31.1
next prev parent reply other threads:[~2021-06-17 19:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 19:09 [PATCH v3 0/9] clk: cs2000-cp: add dynamic mode and more features Daniel Mack
2021-06-17 19:09 ` [PATCH v3 1/9] dt-bindings: clock: convert cs2000-cp bindings to yaml Daniel Mack
2021-06-17 19:09 ` [PATCH v3 2/9] dt-bindings: clock: cs2000-cp: Document aux-output-source Daniel Mack
2021-06-18 20:05 ` Rob Herring
2021-06-17 19:09 ` [PATCH v3 3/9] dt-bindings: clock: cs2000-cp: make clk_in optional Daniel Mack
2021-06-24 21:33 ` Rob Herring
2021-06-28 16:03 ` Daniel Mack
2021-07-01 16:07 ` Rob Herring
2021-07-02 12:34 ` Daniel Mack
2021-06-17 19:09 ` [PATCH v3 4/9] dt-bindings: clock: cs2000-cp: document cirrus,clock-skip flag Daniel Mack
2021-06-24 21:33 ` Rob Herring
2021-06-17 19:09 ` [PATCH v3 5/9] clk: cs2000-cp: Make aux output function controllable Daniel Mack
2021-06-17 19:09 ` [PATCH v3 6/9] clk: cs2000-cp: add support for dynamic mode Daniel Mack
2021-06-17 19:09 ` [PATCH v3 7/9] clk: cs2000-cp: make clock skip setting configurable Daniel Mack
2021-06-17 19:09 ` Daniel Mack [this message]
2021-06-17 19:09 ` [PATCH v3 9/9] clk: cs2000-cp: convert driver to regmap Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210617190912.262809-9-daniel@zonque.org \
--to=daniel@zonque.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).