* [PATCH] dt-bindings: clk: vc5: Fix example
@ 2021-06-07 19:05 Sean Anderson
2021-06-09 20:58 ` Luca Ceresoli
2021-06-18 20:26 ` Rob Herring
0 siblings, 2 replies; 3+ messages in thread
From: Sean Anderson @ 2021-06-07 19:05 UTC (permalink / raw)
To: devicetree, Rob Herring
Cc: linux-clk, Adam Ford, Luca Ceresoli, Sean Anderson
The example properties do not match the binding. Fix them, and prohibit
undocumented properties in clock nodes to prevent this from happening in
the future.
Fixes: 766e1b8608bf ("dt-bindings: clk: versaclock5: convert to yaml")
Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---
.../devicetree/bindings/clock/idt,versaclock5.yaml | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
index 28675b0b80f1..26ed040bc717 100644
--- a/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
+++ b/Documentation/devicetree/bindings/clock/idt,versaclock5.yaml
@@ -84,6 +84,7 @@ patternProperties:
idt,slew-percent:
description: The Slew rate control for CMOS single-ended.
enum: [ 80, 85, 90, 100 ]
+ additionalProperties: false
required:
- compatible
@@ -139,13 +140,13 @@ examples:
clock-names = "xin";
OUT1 {
- idt,drive-mode = <VC5_CMOSD>;
- idt,voltage-microvolts = <1800000>;
+ idt,mode = <VC5_CMOSD>;
+ idt,voltage-microvolt = <1800000>;
idt,slew-percent = <80>;
};
OUT4 {
- idt,drive-mode = <VC5_LVDS>;
+ idt,mode = <VC5_LVDS>;
};
};
};
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: clk: vc5: Fix example
2021-06-07 19:05 [PATCH] dt-bindings: clk: vc5: Fix example Sean Anderson
@ 2021-06-09 20:58 ` Luca Ceresoli
2021-06-18 20:26 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Luca Ceresoli @ 2021-06-09 20:58 UTC (permalink / raw)
To: Sean Anderson, devicetree, Rob Herring; +Cc: linux-clk, Adam Ford
Hi Sean,
On 07/06/21 21:05, Sean Anderson wrote:
> The example properties do not match the binding. Fix them, and prohibit
> undocumented properties in clock nodes to prevent this from happening in
> the future.
>
> Fixes: 766e1b8608bf ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
Ick, how many mistakes did I put in that darn commit?
Reviewed-by: Luca Ceresoli <luca@lucaceresoli.net>
--
Luca
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] dt-bindings: clk: vc5: Fix example
2021-06-07 19:05 [PATCH] dt-bindings: clk: vc5: Fix example Sean Anderson
2021-06-09 20:58 ` Luca Ceresoli
@ 2021-06-18 20:26 ` Rob Herring
1 sibling, 0 replies; 3+ messages in thread
From: Rob Herring @ 2021-06-18 20:26 UTC (permalink / raw)
To: Sean Anderson; +Cc: linux-clk, Adam Ford, devicetree, Luca Ceresoli
On Mon, 07 Jun 2021 15:05:46 -0400, Sean Anderson wrote:
> The example properties do not match the binding. Fix them, and prohibit
> undocumented properties in clock nodes to prevent this from happening in
> the future.
>
> Fixes: 766e1b8608bf ("dt-bindings: clk: versaclock5: convert to yaml")
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>
> ---
>
> .../devicetree/bindings/clock/idt,versaclock5.yaml | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-18 20:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-06-07 19:05 [PATCH] dt-bindings: clk: vc5: Fix example Sean Anderson
2021-06-09 20:58 ` Luca Ceresoli
2021-06-18 20:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).