[RFC PATCH V0 05/10] media: mtk-mdp3: remove unnecessary Null check

Moudy Ho
2021-06-23T07:36:05Z

From: daoyuan huang <daoyuan.huang@mediatek.com>

Remove logically unnecessary NULL check in call back function.

Due to no NULL callback param should occur in normal case;
and if we use NULL check to jump over this clock off step,
the clock ref. count may go asymmetric.

Signed-off-by: daoyuan huang <daoyuan.huang@mediatek.com>
---
drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
index 42a51061677a..df956ca3685c 100644
--- a/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
+++ b/drivers/media/platform/mtk-mdp3/mtk-mdp3-cmdq.c
@@ -349,13 +349,8 @@ static void mdp_auto_release_work(struct work_struct *work)
auto_release_work);
mdp = cb_param->mdp;

- if (cb_param->comps && cb_param->num_comps) {
- int i;
-
- for (i = 0; i < cb_param->num_comps; i++)
- mdp_comp_clock_off(&mdp->pdev->dev,
- &cb_param->comps[i]);
- }
+ mdp_comp_clocks_off(&mdp->pdev->dev, cb_param->comps,
+ cb_param->num_comps);

kfree(cb_param->comps);
kfree(cb_param);
--
2.18.0